chore: replace FormControl with PhoneInput component for phone field#287
Open
harshtandiya wants to merge 1 commit into
Open
chore: replace FormControl with PhoneInput component for phone field#287harshtandiya wants to merge 1 commit into
harshtandiya wants to merge 1 commit into
Conversation
Swap the plain FormControl (type=tel) phone field in ProposalEditDialog.vue
for the shared PhoneInput component so the dial code and number are edited
separately and saved in Frappe's canonical {isd}-{number} format.
This fixes values being saved without the isd- prefix (which render blank
in Desk's Phone field, same class of bug as #244) and prevents casual edits
of existing hyphen-formatted values from corrupting the format.
Fixes #275
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FZ7AVqnfjnXPQbHQd3RVkK
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
harshtandiya has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
harshtandiya
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the phone number input field in the ProposalEditDialog to use a dedicated
PhoneInputcomponent instead of a genericFormControlwithtype="tel".Changes
FormControlwithPhoneInputcomponent for the phone number field in ProposalEditDialogPhoneInputcomponent from@/components/PhoneInput.vuetype="tel"attribute (now handled by the specialized component)v-if,:label,:placeholder, andv-modelbindingImplementation Details
This change improves code organization by using a purpose-built component for phone input handling, which likely includes phone-specific validation, formatting, or accessibility features that were previously missing with the generic FormControl approach.
https://claude.ai/code/session_01FZ7AVqnfjnXPQbHQd3RVkK