Skip to content

fix: correct disabled asset detection, for v1 and v2 - #79

Merged
SupernaviX merged 1 commit into
mainfrom
sg/fix-disabling-collateral
Aug 31, 2026
Merged

fix: correct disabled asset detection, for v1 and v2#79
SupernaviX merged 1 commit into
mainfrom
sg/fix-disabling-collateral

Conversation

@SupernaviX

Copy link
Copy Markdown
Collaborator

Fix some problems with the logic to detect disabled assets:

  1. it was reading the wrong field (weights rather than proportion)
  2. it was not ready for butane v2
  3. for butane v1, it was checking for a zero weight, but the protocol forbids v1 collateral to have 0 proportion. So to actually disable a collateral in v1 (which we need to do because ENCS is too unreliable), we must check for the smallest legal weight instead.

@SupernaviX
SupernaviX merged commit 2b15de2 into main Aug 31, 2026
8 checks passed
@SupernaviX
SupernaviX deleted the sg/fix-disabling-collateral branch August 31, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant