fix: restore count-based outlier quorum in price aggregation - #74
Closed
micahkendall wants to merge 1 commit into
Closed
fix: restore count-based outlier quorum in price aggregation#74micahkendall wants to merge 1 commit into
micahkendall wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
compute_value_in_usdwith a count-based majority check usingtotal_sourcesandcandidate_prices.len()insrc/price_aggregator/conversions.rs.candidate_prices.len() >= 1 + total_sources / 2to proceed.value_in_usd_should_not_allow_single_dominant_weight_source_after_outlier_filteringto assert that a lone dominant-weight source cannot produce a price after outlier filtering.Testing
cargo test -q value_in_usd_should_not_allow_single_dominant_weight_source_after_outlier_filteringwhich passed.cargo test -q value_in_usd_should_not_report_price_if_sources_are_too_far_apartwhich passed.cargo test -q value_in_usd_should_ignore_outlier_sourcewhich passed.Codex Task