Skip to content

Add Windows build script, harden get_genie.ps1, update README and .gitignore - #4

Open
burning-calamity wants to merge 1 commit into
masterfrom
codex/check-the-script-acpblt
Open

burning-calamity wants to merge 1 commit into
masterfrom
codex/check-the-script-acpblt

Conversation

@burning-calamity

Copy link
Copy Markdown
Owner

Motivation

  • Provide a simple, reproducible Windows build entrypoint and document how to build with Visual Studio 2022 using a script.
  • Make the GENie downloader more robust, configurable, and secure to avoid partial/bad downloads and allow checksum verification.

Description

  • Add build.bat to locate MSBuild, perform configurable Release/Debug x64/x32 builds, copy runtime dependencies, write logs under .build, and present user-friendly error output.
  • Extend tools/get_genie.ps1 with parameters -SourceUrl, -ExpectedSha256, -DownloadMethod, -TimeoutSec, -KeepBackup, and -PassThru, plus HTTPS validation, BITS/Invoke-WebRequest selection, temporary-file download, PE header validation, SHA-256 checksum verification, and atomic replacement of the installed genie.exe.
  • Update README.md with a Building on Windows section that documents usage of build.bat and its environment switches like BUILD_NO_PAUSE and example invocations.
  • Update .gitignore to ignore the .build log directory and keep existing project/build ignores.

Testing

  • No automated tests were run for these changes.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be7ac4da3e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread build.bat

set "MSBUILD="
set "VSWHERE=%ProgramFiles(x86)%\Microsoft Visual Studio\Installer\vswhere.exe"
for /f "delims=" %%I in ('where MSBuild.exe 2^>nul') do if not defined MSBUILD set "MSBUILD=%%I"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Select the VS 2022 MSBuild before PATH matches

When the script is run from an older Visual Studio developer prompt, where can select that prompt's MSBuild and prevent the vswhere fallback from running, even if VS 2022 is installed. In the checked projects/clumsy.vcxproj, every configuration requires the v143 toolset, so an older MSBuild can fail with an unavailable-toolset error despite a compatible installation being present; prefer vswhere or validate the PATH candidate before accepting it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant