Repository navigation
[pull] main from apache:main - #286
Merged
Merged
Conversation
…ith 6 updates (#22975) Bumps the all-other-cargo-deps group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [insta](https://github.com/mitsuhiko/insta) | `1.47.2` | `1.48.0` | | [memchr](https://github.com/BurntSushi/memchr) | `2.8.1` | `2.8.2` | | [regex](https://github.com/rust-lang/regex) | `1.12.3` | `1.12.4` | | [uuid](https://github.com/uuid-rs/uuid) | `1.23.2` | `1.23.3` | | [stabby](https://github.com/ZettaScaleLabs/stabby) | `72.1.2` | `72.1.8` | Updates `insta` from 1.47.2 to 1.48.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mitsuhiko/insta/releases">insta's releases</a>.</em></p> <blockquote> <h2>1.48.0</h2> <h2>Release Notes</h2> <ul> <li>Add <code>strip_ansi_escape_codes</code> setting which removes ANSI escape sequences (color codes, cursor movement, etc.) from snapshot content before comparison. Requires the <code>filters</code> feature. <a href="https://redirect.github.com/mitsuhiko/insta/issues/899">#899</a> (<a href="https://github.com/pierluigilenoci"><code>@pierluigilenoci</code></a>)</li> <li>Add opt-in support for YAML literal blocks for multiline strings in snapshot metadata fields such as <code>description</code> and <code>expression</code>. Set <code>INSTA_YAML_BLOCK_STYLE=1</code> to enable. <a href="https://redirect.github.com/mitsuhiko/insta/issues/851">#851</a> (<a href="https://github.com/ivov"><code>@ivov</code></a>)</li> <li>Setting <code>CI=true</code> normally makes <code>cargo insta test</code> behave as though <code>--check</code> was passed. Explicit snapshot handling options such as <code>--accept</code> now take precedence over this environment variable, allowing users to override this behavior if they want to. <a href="https://redirect.github.com/mitsuhiko/insta/issues/924">#924</a></li> <li>Fix <code>cargo insta test --profile</code> being forwarded to nextest as the nextest profile instead of the cargo build profile; it now translates to <code>--cargo-profile</code> for the nextest runner. Add <code>--nextest-profile</code> to select the nextest profile. <a href="https://redirect.github.com/mitsuhiko/insta/issues/910">#910</a></li> <li>Fix <code>cargo insta pending-snapshots</code> printing unusable <code>\\?\</code>-prefixed paths on Windows. The <code>--snapshot</code> filter now also accepts partial paths: any trailing path suffix of the snapshot file matches, so a bare <code>--snapshot my_test.snap</code> works. <a href="https://redirect.github.com/mitsuhiko/insta/issues/904">#904</a></li> <li>Accepting a binary snapshot no longer fails with <code>os error 2</code> when its data file is missing (e.g. gitignored and not committed). <a href="https://redirect.github.com/mitsuhiko/insta/issues/914">#914</a></li> </ul> <h2>Install cargo-insta 1.48.0</h2> <h3>Install prebuilt binaries via shell script</h3> <pre lang="sh"><code>curl --proto '=https' --tlsv1.2 -LsSf https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-installer.sh | sh </code></pre> <h3>Install prebuilt binaries via powershell script</h3> <pre lang="sh"><code>powershell -ExecutionPolicy Bypass -c "irm https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-installer.ps1 | iex" </code></pre> <h2>Download cargo-insta 1.48.0</h2> <table> <thead> <tr> <th>File</th> <th>Platform</th> <th>Checksum</th> </tr> </thead> <tbody> <tr> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-aarch64-apple-darwin.tar.xz">cargo-insta-aarch64-apple-darwin.tar.xz</a></td> <td>Apple Silicon macOS</td> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-aarch64-apple-darwin.tar.xz.sha256">checksum</a></td> </tr> <tr> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-apple-darwin.tar.xz">cargo-insta-x86_64-apple-darwin.tar.xz</a></td> <td>Intel macOS</td> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-apple-darwin.tar.xz.sha256">checksum</a></td> </tr> <tr> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-pc-windows-msvc.zip">cargo-insta-x86_64-pc-windows-msvc.zip</a></td> <td>x64 Windows</td> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-pc-windows-msvc.zip.sha256">checksum</a></td> </tr> <tr> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-unknown-linux-gnu.tar.xz">cargo-insta-x86_64-unknown-linux-gnu.tar.xz</a></td> <td>x64 Linux</td> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-unknown-linux-gnu.tar.xz.sha256">checksum</a></td> </tr> <tr> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-unknown-linux-musl.tar.xz">cargo-insta-x86_64-unknown-linux-musl.tar.xz</a></td> <td>x64 MUSL Linux</td> <td><a href="https://github.com/mitsuhiko/insta/releases/download/1.48.0/cargo-insta-x86_64-unknown-linux-musl.tar.xz.sha256">checksum</a></td> </tr> </tbody> </table> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/mitsuhiko/insta/blob/master/CHANGELOG.md">insta's changelog</a>.</em></p> <blockquote> <h2>1.48.0</h2> <ul> <li>Add <code>strip_ansi_escape_codes</code> setting which removes ANSI escape sequences (color codes, cursor movement, etc.) from snapshot content before comparison. Requires the <code>filters</code> feature. <a href="https://redirect.github.com/mitsuhiko/insta/issues/899">#899</a> (<a href="https://github.com/pierluigilenoci"><code>@pierluigilenoci</code></a>)</li> <li>Add opt-in support for YAML literal blocks for multiline strings in snapshot metadata fields such as <code>description</code> and <code>expression</code>. Set <code>INSTA_YAML_BLOCK_STYLE=1</code> to enable. <a href="https://redirect.github.com/mitsuhiko/insta/issues/851">#851</a> (<a href="https://github.com/ivov"><code>@ivov</code></a>)</li> <li>Setting <code>CI=true</code> normally makes <code>cargo insta test</code> behave as though <code>--check</code> was passed. Explicit snapshot handling options such as <code>--accept</code> now take precedence over this environment variable, allowing users to override this behavior if they want to. <a href="https://redirect.github.com/mitsuhiko/insta/issues/924">#924</a></li> <li>Fix <code>cargo insta test --profile</code> being forwarded to nextest as the nextest profile instead of the cargo build profile; it now translates to <code>--cargo-profile</code> for the nextest runner. Add <code>--nextest-profile</code> to select the nextest profile. <a href="https://redirect.github.com/mitsuhiko/insta/issues/910">#910</a></li> <li>Fix <code>cargo insta pending-snapshots</code> printing unusable <code>\\?\</code>-prefixed paths on Windows. The <code>--snapshot</code> filter now also accepts partial paths: any trailing path suffix of the snapshot file matches, so a bare <code>--snapshot my_test.snap</code> works. <a href="https://redirect.github.com/mitsuhiko/insta/issues/904">#904</a></li> <li>Accepting a binary snapshot no longer fails with <code>os error 2</code> when its data file is missing (e.g. gitignored and not committed). <a href="https://redirect.github.com/mitsuhiko/insta/issues/914">#914</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mitsuhiko/insta/commit/7f23d2e4684a789a85c50503004fb38a23c9ea58"><code>7f23d2e</code></a> Release 1.48.0 (<a href="https://redirect.github.com/mitsuhiko/insta/issues/925">#925</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/ee9cae1eb49cfa80c3d335246b0cfbb6bd006027"><code>ee9cae1</code></a> Allow <code>CI=true</code> to be overridden by an explicitly passed <code>--accept</code> CLI flag ...</li> <li><a href="https://github.com/mitsuhiko/insta/commit/043cf8268e3be93ca684fbfbf3969ad03ad71046"><code>043cf82</code></a> fix: translate --profile to --cargo-profile for nextest (<a href="https://redirect.github.com/mitsuhiko/insta/issues/913">#913</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/9c77f137b160e2235a71770d370fc1b4e7b1f456"><code>9c77f13</code></a> test: cover deep-wildcard redaction through arrays (<a href="https://redirect.github.com/mitsuhiko/insta/issues/915">#915</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/362f432b2d33ca9cdc0fe298a62942b3e13082d2"><code>362f432</code></a> Fix <code>--snapshot</code> filter on Windows; allow partial paths (<a href="https://redirect.github.com/mitsuhiko/insta/issues/904">#904</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/a436836bb22bd1c857f374c8aea6064120680558"><code>a436836</code></a> fix: tolerate a missing binary snapshot data file (<a href="https://redirect.github.com/mitsuhiko/insta/issues/914">#914</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/bf5fcdf1646087b717039011ac9a27cff3b4fc02"><code>bf5fcdf</code></a> fix: regenerate Cargo.lock and guard it with --locked in CI (<a href="https://redirect.github.com/mitsuhiko/insta/issues/912">#912</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/a761a9c937406d8eeab45f23d98d5a2a12105aaf"><code>a761a9c</code></a> feat: Support YAML literal blocks for multiline strings (<a href="https://redirect.github.com/mitsuhiko/insta/issues/851">#851</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/f9633f3a1251a10b8a96243cb941c7834e91288d"><code>f9633f3</code></a> ci: pin <code>check-minver</code> to nightly-2026-04-25 (<a href="https://redirect.github.com/mitsuhiko/insta/issues/905">#905</a>)</li> <li><a href="https://github.com/mitsuhiko/insta/commit/c7b98b8d23846130ce769f86ec8c33b0f221d48e"><code>c7b98b8</code></a> feat: add strip_ansi_escape_codes setting (<a href="https://redirect.github.com/mitsuhiko/insta/issues/899">#899</a>)</li> <li>See full diff in <a href="https://github.com/mitsuhiko/insta/compare/1.47.2...1.48.0">compare view</a></li> </ul> </details> <br /> Updates `memchr` from 2.8.1 to 2.8.2 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/BurntSushi/memchr/commit/a61ac1a3638e8b6bdc42226ad38431e626a02c72"><code>a61ac1a</code></a> 2.8.2</li> <li><a href="https://github.com/BurntSushi/memchr/commit/a08bf90b14b3ee858e7c59286e232879d173d16b"><code>a08bf90</code></a> arch: fix undefined behavior in lower level (but public) APIs</li> <li><a href="https://github.com/BurntSushi/memchr/commit/b41293b805c2709ef19d98f9b1191ca2e3a4e7c8"><code>b41293b</code></a> rebar: update memchr to latest</li> <li><a href="https://github.com/BurntSushi/memchr/commit/87467c9ca52d40bb68978c1c7dc92097d0289833"><code>87467c9</code></a> impl: remove unnecessary clones in <code>into_owned</code> impls</li> <li>See full diff in <a href="https://github.com/BurntSushi/memchr/compare/2.8.1...2.8.2">compare view</a></li> </ul> </details> <br /> Updates `regex` from 1.12.3 to 1.12.4 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/regex/blob/master/CHANGELOG.md">regex's changelog</a>.</em></p> <blockquote> <h1>1.12.4 (2025-06-09)</h1> <p>This release includes a performance optimization for compilation of regexes with very large character classes.</p> <p>Improvements:</p> <ul> <li><a href="https://redirect.github.com/rust-lang/regex/pull/1308">#1308</a>: Avoid re-canonicalizing the entire interval set when pushing new class ranges.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/regex/commit/7b96fdc9d5fe6a0cb4efe30e6689b050493fc1e1"><code>7b96fdc</code></a> 1.12.4</li> <li><a href="https://github.com/rust-lang/regex/commit/7b89cf0534aa58ab8a4a6672e14a59b53f08eb2c"><code>7b89cf0</code></a> deps: update to regex-syntax 0.8.11</li> <li><a href="https://github.com/rust-lang/regex/commit/140167995737fa11dfe11b8af8b9aa143b790b4e"><code>1401679</code></a> regex-syntax-0.8.11</li> <li><a href="https://github.com/rust-lang/regex/commit/d7090000b3be51677d8e79c3b8bcc8a4d176bddc"><code>d709000</code></a> changelog: 1.12.4</li> <li><a href="https://github.com/rust-lang/regex/commit/9825c741c8ac1e61e8f78cebc12205cd35e4767f"><code>9825c74</code></a> syntax: avoid re-canonicalizing the entire IntervalSet on push (<a href="https://redirect.github.com/rust-lang/regex/issues/1308">#1308</a>)</li> <li><a href="https://github.com/rust-lang/regex/commit/a7f2ff6dbc43f40994d7c3d1d968ba4ac92329e1"><code>a7f2ff6</code></a> docs: clarify regex-lite word boundaries</li> <li><a href="https://github.com/rust-lang/regex/commit/2c7b17246da744bb2e1b911d3ddc1369fe3b472a"><code>2c7b172</code></a> docs: clarify unsupported Anchored::Pattern searches</li> <li><a href="https://github.com/rust-lang/regex/commit/839d16bc65b60e2006d3599d20bfa6efc14049d8"><code>839d16b</code></a> regex-syntax-0.8.10</li> <li><a href="https://github.com/rust-lang/regex/commit/c4865a0c8446a701e10b0fd987f19068f5dcc365"><code>c4865a0</code></a> syntax: fix negation handling in HIR translation</li> <li><a href="https://github.com/rust-lang/regex/commit/d8761c00ed25c5899e3dcfb0f17e827b8e41530a"><code>d8761c0</code></a> cargo: also include <code>benches</code></li> <li>Additional commits viewable in <a href="https://github.com/rust-lang/regex/compare/1.12.3...1.12.4">compare view</a></li> </ul> </details> <br /> Updates `uuid` from 1.23.2 to 1.23.3 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuid-rs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v1.23.3</h2> <h2>What's Changed</h2> <ul> <li>Fix up parser panic on empty input by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/uuid-rs/uuid/pull/886">uuid-rs/uuid#886</a></li> <li>Prepare for 1.23.3 release by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/uuid-rs/uuid/pull/887">uuid-rs/uuid#887</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/uuid-rs/uuid/compare/v1.23.2...v1.23.3">https://github.com/uuid-rs/uuid/compare/v1.23.2...v1.23.3</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/uuid-rs/uuid/commit/20da78b1813319c8017d107089caec1ff9d6b1a8"><code>20da78b</code></a> Merge pull request <a href="https://redirect.github.com/uuid-rs/uuid/issues/887">#887</a> from uuid-rs/cargo/v1.23.3</li> <li><a href="https://github.com/uuid-rs/uuid/commit/62232ca120b1b09eea5979ca966e9669705e8841"><code>62232ca</code></a> prepare for 1.23.3 release</li> <li><a href="https://github.com/uuid-rs/uuid/commit/2320c6a0335cfddaec4df58d1a7fe410070ab9e9"><code>2320c6a</code></a> Merge pull request <a href="https://redirect.github.com/uuid-rs/uuid/issues/886">#886</a> from uuid-rs/fix/parser-panics</li> <li><a href="https://github.com/uuid-rs/uuid/commit/2d034d41a518b0a103e96d47e04690f6644de487"><code>2d034d4</code></a> fix some invalid indexers on error reporting</li> <li><a href="https://github.com/uuid-rs/uuid/commit/a8b9f142678d9640ba6dc80c5e2d69635d4dd62f"><code>a8b9f14</code></a> update fuzz infra and run in CI</li> <li>See full diff in <a href="https://github.com/uuid-rs/uuid/compare/v1.23.2...v1.23.3">compare view</a></li> </ul> </details> <br /> Updates `stabby` from 72.1.2 to 72.1.8 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/ZettaScaleLabs/stabby/blob/main/CHANGELOG.md">stabby's changelog</a>.</em></p> <blockquote> <h1>72.1.8 (api=3.0.3, abi=2.0.0)</h1> <ul> <li>Make builds more reproducible <a href="https://redirect.github.com/ZettaScaleLabs/stabby/pull/136">#136</a> (thanks <a href="https://github.com/pablo-smith-saronic"><code>@pablo-smith-saronic</code></a> for raising the issue and providing the fix)</li> <li>Fix CI for Rust 1.72, fix support for 1.72</li> <li>Enable more lints to prevent unexpected panics</li> </ul> <h1>72.1.4 (api=3.0.2, abi=2.0.0)</h1> <ul> <li>Upgraded <code>syn</code> to <code>2.0.46+</code>.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/ZettaScaleLabs/stabby/commits">compare view</a></li> </ul> </details> <br /> Updates `regex-syntax` from 0.8.10 to 0.8.11 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/regex/commit/140167995737fa11dfe11b8af8b9aa143b790b4e"><code>1401679</code></a> regex-syntax-0.8.11</li> <li><a href="https://github.com/rust-lang/regex/commit/d7090000b3be51677d8e79c3b8bcc8a4d176bddc"><code>d709000</code></a> changelog: 1.12.4</li> <li><a href="https://github.com/rust-lang/regex/commit/9825c741c8ac1e61e8f78cebc12205cd35e4767f"><code>9825c74</code></a> syntax: avoid re-canonicalizing the entire IntervalSet on push (<a href="https://redirect.github.com/rust-lang/regex/issues/1308">#1308</a>)</li> <li><a href="https://github.com/rust-lang/regex/commit/a7f2ff6dbc43f40994d7c3d1d968ba4ac92329e1"><code>a7f2ff6</code></a> docs: clarify regex-lite word boundaries</li> <li><a href="https://github.com/rust-lang/regex/commit/2c7b17246da744bb2e1b911d3ddc1369fe3b472a"><code>2c7b172</code></a> docs: clarify unsupported Anchored::Pattern searches</li> <li>See full diff in <a href="https://github.com/rust-lang/regex/compare/regex-syntax-0.8.10...regex-syntax-0.8.11">compare view</a></li> </ul> </details> <br /> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tions` (#22969) ## Which issue does this PR close? - Closes #. ## Rationale for this change Something that was spotted during the review of: - #22657 `ListingOptions::target_partitions` and `ListingOptions::collect_stat` duplicate `SessionConfig`'s `execution.target_partitions` and `execution.collect_statistics`. After some investigation, I think they only live on `ListingOptions` for historical reasons: when the struct was added (#1010 5 years ago), `TableProvider::scan` had no access to the session, so the values had to be copied onto the table at build time. Once #2660 passed `SessionState` into `scan`, the fields became redundant (and had already drifted — `scan` read them from the session config while `list_files_for_scan` read the stale copy). This PR makes `SessionConfig` the single source of truth. ## What changes are included in this PR? - Remove `target_partitions`/`collect_stat` fields, their builders, and `with_session_config_options` from `ListingOptions`. - `ListingTable` now reads both values from the session config at scan time. - Reserve proto tags 8/9 in `ListingTableScanNode` and drop the related (de)serialization. - Update benchmarks, factory, and test call sites. ## Are these changes tested? Yes, by existing tests ## Are there any user-facing changes? Yes, breaking: the removed fields/builders require configuring `SessionConfig` instead, and the two proto fields no longer round-trip. --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )