Repository navigation
[pull] main from apache:main - #273
Merged
Merged
Conversation
## Which issue does this PR close? - related to apache/arrow-rs#9110 ## Rationale for this change Update to latest version of arrow/parquet ## What changes are included in this PR? 1. Update to arrow/parquet 59.0.0 2. Adjust code for API differences ## Are these changes tested? By CI ## Are there any user-facing changes? New dependency
## Which issue does this PR close? Closes #22662. ## Rationale for this change Async scalar UDFs can compute output field metadata in `return_field_from_args(...)`, but `AsyncFuncExpr` rebuilt the output field from only name, data type, and nullability. This dropped metadata from async UDF result fields. ## What changes are included in this PR? This PR updates `AsyncFuncExpr::field(...)` to preserve the planned `return_field` metadata and only rename the field for the async expression output. It also adds a regression test that verifies an async UDF result batch preserves metadata attached by `return_field_from_args(...)`. ## Are these changes tested? Yes. Added a regression test in: - `datafusion/core/tests/user_defined/user_defined_async_scalar_functions.rs` The test fails without the fix and passes with the fix. ## Are there any user-facing changes? Yes. Async scalar UDF result fields now preserve metadata attached by `return_field_from_args(...)`. --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )