Repository navigation
[pull] main from apache:main - #263
Merged
Merged
Conversation
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - Closes #14770 . ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Add `fill_nan` and test by referencing the `fill_null` mirror. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Add a new function. --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
## Which issue does this PR close? - Closes #22773 . ## Rationale for this change Aggregate and window aggregate `FILTER` clauses currently fail with an internal error when the filter condition is `NULL`, even though the equivalent boolean-typed expression (e.g. `CAST(NULL AS BOOLEAN)`) works correctly. This occurs because `FILTER` predicates are not being coerced to `BOOLEAN` during type coercion. ## What changes are included in this PR? * Coerce aggregate `FILTER` predicates to `BOOLEAN` during type coercion. * Apply the same coercion to window aggregate `FILTER` predicates. * Add SQL logic tests covering `FILTER (WHERE NULL)` for both aggregate and window aggregate functions. ## Are these changes tested? Yes. Added SQL logic tests covering: * `COUNT(*) FILTER (WHERE NULL)` * `COUNT(1) FILTER (WHERE NULL)` * `SUM(1) FILTER (WHERE NULL)` * `AVG(1) FILTER (WHERE NULL)` * Window aggregate variants using `FILTER (WHERE NULL)` ## Are there any user-facing changes? Yes. Queries using `FILTER (WHERE NULL)` no longer fail with an internal error and now return the expected results. Also, no changes were made to any public APIs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )