refactor: decompose GenerateQRHandler into focused components (004)#26
Merged
Merged
Conversation
Extract DynamicQRCodeResolver service from GenerateQRHandler to follow SRP: - DynamicQRCodeResolver: short code generation, collision resolution, redirect URL building - DynamicQRSetup: immutable DTO for dynamic QR preparation result Refactor GenerateQRHandler into 4-phase architecture: 1. _prepare_content() — build content + optional dynamic setup 2. _generate_image() — QR image I/O (outside transaction) 3. _persist_with_retry() — DB writes with collision retry 4. Event publishing with BaseEvent.with_updated() Key improvements: - I/O (image generation) now happens OUTSIDE database transactions - Collision handling simplified: single check per tx, retry externally - BaseEvent.with_updated() replaces fragile manual event reconstruction - DI container wired with new singleton services Tests: 1667 passed (18 new tests for DynamicQRCodeResolver + BaseEvent.with_updated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract DynamicQRCodeResolver service from GenerateQRHandler to follow SRP:
Refactor GenerateQRHandler into 4-phase architecture:
Key improvements:
Tests: 1667 passed (18 new tests for DynamicQRCodeResolver + BaseEvent.with_updated)