Repository navigation
chore(release): 0.9.0 - #104
Conversation
|
Claude finished @krassx's task in 24s —— View job Review of #104: chore(release): 0.9.0No blocking issues found. I did not post inline comments because I found nothing that needs a code change. I read the diff against What I checked
Nits (P3, optional)
Overall risk: Low. The change is a version bump plus changelog. Merge recommendation: Approve and merge. Tag Most important to fix: nothing blocking. The Positives
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Change: Other Merge Risk:
|
There was a problem hiding this comment.
Stale comment
Release PR: version bump 0.8.2 → 0.9.0 and fold of
[Unreleased]into dated 0.9.0 notes. Reviewed against every commit sincev0.8.2, the shipping code for those changes,dist plan, and this PR's CI logs — not the diff alone.Findings
P3 Low — 0.9.0 footnote definitions sit under 0.7.7, so the GitHub Release will not hyperlink them
Location:
CHANGELOG.md(defs after the 0.7.7 section; they belong immediately after the 0.9.0 bullets)Problem: cargo-dist copies only the matching version section into the GitHub Release body. This PR's
planjob already showsannouncement_changelogending at the Changed paragraph, with no[#86]:/[#99]:/[#103]:definitions. v0.8.2's published notes did include[#96]:because that definition sat under the 0.8.2 section (same for 0.8.1/[#78], 0.8.0/[#69]).Impact: The public v0.9.0 announcement is the GitHub Release.
[#86],[#99],[#103], etc. will render as unresolved markdown references instead of links.Scenario: Tag
v0.9.0→release.ymlannounceusesannouncement_github_bodyfrom plan → Release notes contain[#99]with no definition.Fix: Move those six definitions to sit after the 0.9.0 Changed bullet (before
## [0.8.2]). Optionally cite#98on the panic bullet, which currently has no PR link.CI (not caused by this diff)
test (windows-latest)failed:cli::debug_files::sourcemap_upload_tests::uploads_overlap_unless_concurrency_is_oneexpected the first PUT after 4 POSTs, observed["POST", "PUT", ...]. The 150ms POST delay is a timing flake on a loaded Windows runner. This PR does not touch that test. ubuntu-latest and windows-11-arm passed; self-update jobs on both Windows hosts passed.Checks that held
- Commits since
v0.8.2are all in the notes: #99/#86 (portable-pdb → BMF), #98 (panic 1/50), #103 (Windows leftover sweep), #97 (self-replace 1.5.1), #100/#102 (Windows self-update CI).- Claims match the shipping code (
convert_allstages then publishes; mismatched pdb is exit 11 and uploads nothing; leftover sweep is 32 lowercase letters; lockfile is self-replace 1.5.1).- 0.9.0 is the right bump: new opt-in command; exit 50 is additive; 101 → 1/50 is the #98 fix. Auto-update stays on
cli/v0.x/.Cargo.toml/Cargo.lock/cargo metadataare 0.9.0.dist plan:announcement_title0.9.0 - 2026-11-04, tagv0.9.0. Empty[Unreleased]kept, same shape as 0.8.2.Overall
- Overall risk: Low
- Merge recommendation: Approve the bump once
test (windows-latest)is green (re-run that job). Move the 0.9.0 footnote definitions under that section before tagging so the GitHub Release links resolve.- Most important to fix: Green CI, then the footnote placement. Do not bump integrator floors until the worker side of portable-pdb is in production — the notes already say it is on staging, and
--type portable-pdbis opt-in.- What looks good: Tight release PR; notes match git and code; semver and cargo-dist announcement extraction are correct; Windows leftover sweep and panic-exit fold are accurate.
Sent by Cursor Automation: Bugsee code review
cargo-dist copies only the version's own section into the GitHub Release, so definitions left under 0.7.7 would render as unresolved references there. Also link the panic-exit fix (#98). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxQWhjhQvvURAjiDkti
|
Claude finished @krassx's task in 20s —— View job Re-review of #104 after the latest push: no new findingsI re-read Earlier findings now fixed
Still true
CI
Summary
|
There was a problem hiding this comment.
Re-review of #104 at db5a3cd (prior 65d3213). Release PR: version bump 0.8.2 → 0.9.0 and fold of [Unreleased] into dated 0.9.0 notes. Rechecked against every commit since v0.8.2, the shipping code for those changes, this head's dist plan, and current CI — not the diff alone.
Findings
No P0–P3 remaining.
The previous P3 (0.9.0 footnote definitions sitting under 0.7.7) is fully addressed. The seven defs now sit immediately after the 0.9.0 Changed bullets (CHANGELOG.md:47-53), the panic bullet cites [#98], and this head's plan job announcement_changelog includes [#86]: through [#103]:. Tagging v0.9.0 will therefore hyperlink those references in the GitHub Release.
Checks that held
- Commits since
v0.8.2are all in the notes: #99/#86 (portable-pdb → BMF), #98 (panic 1/50), #103 (Windows leftover sweep), #97 (self-replace 1.5.1), #100/#102 (Windows self-update CI). - Claims still match the shipping code (
convert_allstages then publishes; mismatched pdb is exit 11 and uploads nothing; leftover sweep is this binary's stem plus a 32-letter lowercase id; lockfile is self-replace 1.5.1;catch_unwindmaps panic to 1/50). - 0.9.0 is the right bump: new opt-in command; exit 50 is additive; 101 → 1/50 is the #98 fix. Auto-update stays on
cli/v0.x/. Cargo.toml/Cargo.lock/cargo metadataare 0.9.0.dist plan:announcement_title0.9.0 - 2026-11-04, tagv0.9.0. Empty[Unreleased]kept.
CI
On this head (41856153783): test (windows-latest) passed, as did ubuntu-latest, windows-11-arm, both Windows self-update jobs, clippy, rustfmt, and the Windows/Linux e2e legs. macos was still queued when this review ran; that is runner capacity, not this diff. The earlier sourcemap-concurrency flake on 65d3213 did not reproduce.
Overall
- Overall risk: Low
- Merge recommendation: Approve. Tag
v0.9.0on the merge commit as described in the PR;release.ymlthennpm-publish.yml/mirror-to-s3.ymlchain off it. - Most important to fix: nothing outstanding in the diff. Do not bump integrator floors until the worker side of portable-pdb is in production — the notes already say it is on staging, and
--type portable-pdbis opt-in. - What looks good: Tight release PR; the footnote follow-up matches how cargo-dist extracts the GitHub Release body; notes match git and code; semver is correct; Windows leftover sweep and panic-exit fold remain accurate.
Sent by Cursor Automation: Bugsee code review


Release 0.9.0
Version bump (
Cargo.toml,Cargo.lock) and the changelog entry. Nothing else.Added
debug-files upload --type portable-pdbandconvert --to bmf: Unity Mono Release builds symbolicate (Portable PDB / Mono: implement debug-files convert --to bmf (or a real portable-pdb upload) for Unity Release Mono #86, feat: upload Unity Mono portable pdbs as BMF symbols (#86) #99). New capability, so an integrator needs a 0.9.0 floor before using it.Fixed
bugsee-cli updateon Windows sweeps leftover binaries from earlier updates (fix(update): sweep what an earlier Windows update left behind #103).Changed
self-replace1.5.1 (chore(deps): bump self-replace from 1.5.0 to 1.5.1 in the cargo-minor-patch group #97); the Windowsupdatepath now has its own CI check on x64 and ARM64 (test(ci): exercise the Windows self-replace for real, as its own check #100, test(ci): say what the self-update test can and cannot observe #102, fix(update): sweep what an earlier Windows update left behind #103).Checked here:
cargo clippy --all-targets -- -D warnings,cargo test(all suites green, 692 unit tests),--versionprints 0.9.0.After merge: tag
v0.9.0on the merge commit. That runsrelease.yml, thennpm-publish.ymlandmirror-to-s3.ymlchain off it. I have not tagged anything.🤖 Generated with Claude Code
https://claude.ai/code/session_01WeiJxQWhjhQvvURAjiDkti