build: drop Node 18 EOL, add Node 24 and 25 support - #115
Closed
buffcode wants to merge 1 commit into
Closed
Conversation
Wrap NtpPacketParser.parse() in try/catch inside the dgram message listener so a parse failure rejects the pending promise cleanly instead of escaping as an uncaughtException. This matters once the parser lands input validation (it will throw TypeError on non-48-byte or non-Buffer inputs); without this guard a single malformed UDP response would crash the host Node process. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing this PR as it was accidentally opened from the wrong branch ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodedev dependency range accordinglyChanges
.github/workflows/nodejs.yml: matrix['18','20','22']→['20','22','24','25']package.jsonengines:^18 || ^20 || ^22→^20 || ^22 || ^24 || ^25package.json@types/node: same range update