Fix regression in Violation.RuleValue for native rules#325
Merged
Conversation
The value passed to construct a Violation.RuleValue regressed as part of PR #316. Instead of containing the value of the in/not_in rule, it contained the value of the invalid value. Update the native rules to construct the rule value for in/not_in rules and use it when creating the violation. Add regression tests to verify the shape of the violation. Fixes #323.
|
The latest Buf updates on your PR. Results from workflow Buf / validate-protos (pull_request).
|
jonbodner-buf
requested changes
Jun 15, 2026
Add an e2e test that verifies the CEL violation matches the native rule violation. Fix a few more cases where the rule value didn't match.
pkwarren
changed the title
jonbodner-buf
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value passed to construct a Violation.RuleValue regressed as part of PR #316.
Update the native rules to fix inconsistencies between the CEL rules and the native rules. Add regression tests to verify the shape of the violation.
Fixes #323.