Skip to content

PROD-10339 - Fix: Group Type list not appearing in the select dropdown on the Group Settings page (frontend) when ReadyLaunch is enabled #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sajib-bb wants to merge 1 commit into
base: release
Choose a base branch
from
Open

PROD-10339 - Fix: Group Type list not appearing in the select dropdown on the Group Settings page (frontend) when ReadyLaunch is enabled #5038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/bp-templates/bp-nouveau/readylaunch/groups/single/admin/group-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,16 @@
<select id="bp-groups-type" name="group-types[]" autocomplete="off">
<option value="" <?php selected( '', '' ); ?>><?php esc_html_e( 'Select Group Type', 'buddyboss' ); ?></option>
<?php
// `wp_kses_post()` strips `<option>`/`<select>` as they're not part of the post-content
// allowed-tags list, so a dedicated allowlist is used instead to keep these options intact.
$group_type_option_allowed_html = array(
'option' => array(
'for' => true,
'value' => true,
'selected' => true,
),
);

foreach ( $group_types as $group_type ) :

$group_option = sprintf(
Expand Down Expand Up @@ -249,19 +259,19 @@

if ( ! empty( $include_group_type ) ) {
if ( in_array( $group_type->name, $include_group_type, true ) ) {
echo wp_kses_post( $group_option );
echo wp_kses( $group_option, $group_type_option_allowed_html );
}
} else {
echo wp_kses_post( $group_option );
echo wp_kses( $group_option, $group_type_option_allowed_html );
}
} else {
echo wp_kses_post( $group_option );
echo wp_kses( $group_option, $group_type_option_allowed_html );
}
} else {
echo wp_kses_post( $group_option );
echo wp_kses( $group_option, $group_type_option_allowed_html );
}
} else {
echo wp_kses_post( $group_option );
echo wp_kses( $group_option, $group_type_option_allowed_html );
}
endforeach;
?>
Expand Down
Loading