fix(ci): isolate pytest-check-links so Max Versions matrix can collect#927
Merged
Conversation
The Max Versions matrix (uv sync --resolution=highest) pulls pytest 9.1, which removed the legacy `path` argument from the pytest_collect_file hookspec. pytest-check-links 0.10.1 caps pytest<9 in its metadata, so an unconstrained max-versions resolve backtracks to 0.9.1 (no cap) and installs it next to pytest 9 — its hookimpl still declares `path`, so pluggy raises PluginValidationError at startup and aborts collection for the whole unit suite. Failure is unrelated to test content and distinct from the post-summary SIGABRT that run_pytest_tolerant.sh handles. pytest-check-links is docs tooling, not a buckaroo runtime dependency: only the CheckDocs job runs `pytest --check-links`. Move it out of the shared dev deps into a dedicated `linkcheck` group (pinned >=0.10.1 with an explicit pytest<9 belt), install that group only in CheckDocs, and add `--no-group linkcheck` to Max Versions (mirroring --no-group datacompy). Verified: a faithful max-versions resolve no longer installs pytest-check-links and collects all unit tests; the CheckDocs env keeps pytest-check-links 0.10.1 under pytest<9 with --check-links registered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📦 TestPyPI package publishedpip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.14.20.dev27551847546or with uv: uv pip install --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo==0.14.20.dev27551847546MCP server for Claude Codeclaude mcp add buckaroo-table -- uvx --from "buckaroo[mcp]==0.14.20.dev27551847546" --index-strategy unsafe-best-match --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple/ buckaroo-table📖 Docs preview🎨 Storybook preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Python / Test (Max Versions) matrix fails at "Run tests" with exit code 1, before any test runs:
Seen on run 27550697421 (hit while another PR was open; fixing it properly here).
Cause
Fully deterministic in the pytest version:
uv sync --resolution=highest, pulling pytest 9.1.0.path(py.path) argument from thepytest_collect_filehookspec.pytest-check-links0.10.1 capspytest<9in its own metadata, so the max-versions resolve can't use it and backtracks to 0.9.1 (no cap), installing it next to pytest 9.1.path, so pluggy's startup validation raisesPluginValidationErrorand aborts collection for the entire unit suite.This is unrelated to test content and distinct from the post-summary polars/pyo3 SIGABRT (exit 134) that
scripts/run_pytest_tolerant.shhandles — this is exit 1 during collection. It only hits Max Versions; the locked matrices use an older pytest where the plugin loads fine.pytest-check-linksis docs tooling, not a buckaroo runtime dependency — only the CheckDocs job runspytest --check-links(checks.yml). It has no business in the Max Versions matrix.Fix
pytest-check-linksout of the shareddevdeps into a dedicatedlinkcheckdependency-group, pinned>=0.10.1with an explicitpytest<9belt.linkcheckonly in CheckDocs (--group linkcheck).--no-group linkcheck, mirroring the existing--no-group datacompy.Verification
PluginValidationError; pytest 8.4.2 → loads fine.--resolution=highest ... --no-group linkcheck): pytest-check-links absent, all 1212 unit tests collect with no error.--group linkcheck): pytest-check-links 0.10.1 under pytest<9,--check-linksoption registered, plugin loads cleanly.artifact_testfailures are pre-existing in this checkout — they need a built dist artifact and fail identically onmain).🤖 Generated with Claude Code