Adding a new caption position: Below the Slide - #39
Open
dg4220 wants to merge 24 commits into
Open
Conversation
…tilizes js to check the height of the tallest caption div and relocates the caption and navigation based on those values.
…p of the "under the slide" captions at the bottom edge of the tallest slide image and locate the navigation just above the bottom edge of the tallest image. This can have mixed visual results if the images are of signifigantly different sizes but it does keep the navigation from being pushed off the page by long captions.
…heme customizations.
Contributor
Author
|
There will be a fair amount of documentation to update but I wanted you guys to get a look at this; it's supposed to work particularly with Learning Modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to position a caption below the slide. It updates the navigation positioning so it's based on the image height rather than the slide height. This prevents pushing the navigation off the screen when using longer captions or viewing on smaller screens.