Fix10 - #215
Merged
Merged
Conversation
The node echoes back a 32-byte key as the identity regardless of whether a link exists, so checking `mldsaHashedPublicKey` presence was a false positive on first link — causing the reveal to be skipped and the transaction to be rejected. Now `mldsaLinked` is used as the authoritative signal when present. Falls back to the old `mldsaHashedPublicKey` check for older nodes that don't include the field.
Update `opnet` from `^1.9.1` to `^1.10.0` in `package.json` and refresh the lockfile to align installed dependency metadata with the new version.
There was a problem hiding this comment.
Pull request overview
This PR updates ML-DSA on-chain linkage detection to avoid false positives caused by nodes echoing back a queried 32-byte key, and bumps the app/dependency versions to align with the newer OPNet behavior.
Changes:
- Use
mldsaLinked(when available) as the authoritative on-chain linkage indicator, falling back to legacy behavior for older nodes. - Apply the updated linkage logic both in the background controller and in the Tx confirmation UI path that bypasses the controller.
- Bump
opwalletversion to1.9.1and updateopnetdependency to^1.10.0(with lockfile updates).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ui/pages/Wallet/TxOpnetConfirmScreen.tsx | Updates ML-DSA “already linked” detection to prefer mldsaLinked and avoid false positives during deployment signing. |
| src/background/controller/wallet.ts | Fixes isMLDSALinkedOnChain to use mldsaLinked as authoritative, preventing skipped reveals that would cause rejected transactions. |
| package.json | Bumps app version and updates opnet dependency. |
| package-lock.json | Locks opnet to 1.10.0 and updates integrity metadata accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4969
to
+4974
| // `mldsaLinked` is authoritative. `mldsaHashedPublicKey` is NOT a linkage | ||
| // signal: when the node is queried with a 32-byte key it echoes that key | ||
| // back as the identity whether or not a link exists, so keying off its | ||
| // presence reports a false positive on a first link, skips the reveal and | ||
| // gets the transaction rejected. Nodes older than that field omit it, so | ||
| // fall back to the previous behaviour rather than always revealing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Checklist
Build & Tests
npm installcompletes without errorsnpm run build:chromebuilds successfullyCode Quality
Documentation
Security
OPWallet Specific
Testing
Browser Testing
Screenshots
Related Issues
By submitting this PR, I confirm that my contribution is made under the terms of the project's license.