Skip to content

refactor(cmd): fix error handling and linter warnings in CLI and loaders (5/5) - #16

Open
bstoll wants to merge 1 commit into
mainfrom
cleanup-5-5-cli-and-repo-lint
Open

refactor(cmd): fix error handling and linter warnings in CLI and loaders (5/5)#16
bstoll wants to merge 1 commit into
mainfrom
cleanup-5-5-cli-and-repo-lint

Conversation

@bstoll

@bstoll bstoll commented Jul 9, 2026

Copy link
Copy Markdown
Owner

This is part 5/5 of an overall cleanup effort to fix golangci-lint violations and format files across the repository. In this step:

  • Handle errors returned by viper.BindPFlags in command root and topology tests.
  • Standardize error message capitalization in CLI and loader modules.
  • Rename test variables for clarity (DNE -> Missing).

@bstoll
bstoll force-pushed the cleanup-5-5-cli-and-repo-lint branch from 36d67e9 to 2413d4e Compare July 9, 2026 17:54
@coveralls

coveralls commented Jul 9, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 29054969368

Coverage decreased (-0.01%) to 42.044%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: 13 uncovered changes across 4 files (0 of 13 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
deploy/deploy.go 5 0 0.0%
cmd/root.go 3 0 0.0%
load/deploy.go 3 0 0.0%
cmd/deploy/deploy.go 2 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 12337
Covered Lines: 5187
Line Coverage: 42.04%
Coverage Strength: 0.48 hits per line

💛 - Coveralls

@bstoll
bstoll force-pushed the cleanup-5-5-cli-and-repo-lint branch 9 times, most recently from f296d87 to d2a7870 Compare July 9, 2026 18:48
…s (5/5)

This is part 5/5 of an overall cleanup effort to fix linter issues and format files across the repository.
In this step:
- Handle errors returned by viper.BindPFlags in command root and topology tests.
- Standardize error message capitalization in CLI and loader modules.
- Rename test variables for clarity (DNE -> Missing).
- Remove new-from-rev from .golangci.yml to enforce full repository linting (check all) going forward.
@bstoll
bstoll force-pushed the cleanup-5-5-cli-and-repo-lint branch from d2a7870 to c163b99 Compare July 9, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants