Golangci lint fixes - #10
Open
bstoll wants to merge 2 commits into
Open
Conversation
Coverage Report for CI Build 28976590405Coverage decreased (-0.08%) to 41.978%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions345 previously-covered lines in 13 files lost coverage.
Coverage Stats
💛 - Coveralls |
bstoll
force-pushed
the
golangci-lint-fixes
branch
10 times, most recently
from
June 30, 2026 00:26
41a77ca to
3947ce2
Compare
bstoll
force-pushed
the
golangci-lint-fixes
branch
3 times, most recently
from
July 7, 2026 21:58
66d7518 to
ddef5ed
Compare
bstoll
force-pushed
the
golangci-lint-fixes
branch
4 times, most recently
from
July 8, 2026 17:47
d8b63fe to
67bcff2
Compare
This change aggregates several fixes to address golangci-lint violations, format code files, and update deprecated APIs. Key changes: - Refactored Go code to address golangci-lint violations and update deprecated APIs: - Replaced deprecated `k8s.io/utils/pointer` with `k8s.io/utils/ptr`. - Replaced deprecated `grpc.DialContext` with `grpc.NewClient`. - Handled or logged errors from `CloseSend`, `ReadFrom`, `BindPFlags`, etc. - Standardized error message capitalization (removed leading capitals and ending punctuation). - Simplified boolean expressions and struct field accesses. - Addressed various linter-raised spelling errors and style comments (e.g. in `topo/node/sonic` and other nodes). - Renamed internal fields for better readability (e.g., `wantInitCtr` to `wantInitContainer` and `wantSonicCtr` to `wantSonicContainer` in `sonic.go`). - Ran `go fmt` across all Go source files. - Formatted YAML files and manifests according to linter configurations (added `---` document start markers, fixed spacing/indentation in cloudbuild config, deployments, and various topological templates). - Updated configuration files for Super-Linter: - Added codespell configuration file `.github/linters/.codespellrc`. - Adjusted `.golangci.yml` linter settings. - Added rules to `.github/linters/.checkov.yaml`, `.github/linters/.gitleaks.toml`, etc. - Added dependency cooldown periods in `.github/dependabot.yml`. - Ran Prettier on all Markdown files in the repository to ensure consistent styling.
bstoll
force-pushed
the
golangci-lint-fixes
branch
from
July 8, 2026 21:21
67bcff2 to
ccbe258
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.