Backgrounds - #9
Open
LordKraken wants to merge 8 commits into
Open
Conversation
As the title says, all warning should be fixed for all 4 differents configurations.
Resolution is not better since it would require heavy changes, but the background textures have been remade from HD pictures of the consoles.
Author
|
Made a small mistake when creating the background branch, so it contains also all warning fixes from master. |
Template background files.
42Bastian
reviewed
Apr 15, 2020
| FILE* fp; | ||
| errno_t err; | ||
| if ((err = fopen_s(&fp, filename, "rb")) != 0) { | ||
| if ((err = fopen_s(&fp, filename, "rb")) == 0) { |
There was a problem hiding this comment.
IMHO the variable err and the assignment in the if () can be omitted as it is not used.
Also true for most if not all fopen_s.
Author
There was a problem hiding this comment.
Nice catch, I actually fixed it in my fork, I made this mistake a couple of time in this PR actually.
fopen return 0/NULL -> didnt work
fopen_s return 0 -> All fine
Pretty confusing ^^
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New backgrounds.