Added min function & Updated platform toolset for Visual Studio 2019 - #7
Open
panda668 wants to merge 1 commit into
Open
Added min function & Updated platform toolset for Visual Studio 2019#7panda668 wants to merge 1 commit into
panda668 wants to merge 1 commit into
Conversation
Added min function
LordKraken
reviewed
May 26, 2019
|
|
||
| // Function members | ||
|
|
||
| #define min(x,y) x>y?y:x |
There was a problem hiding this comment.
I would add parenthesis: #define min(x,y) ((x)>(y)?(y):(x))
There was a problem hiding this comment.
edit: what about just replacing min with __min, that's the one from windows stdlib apparently.
There was a problem hiding this comment.
I would even go for:
#define min(x,y) ((x)>(y)?y:x)
And: No Compiler/platform dependency if not needed.
LordKraken
suggested changes
May 26, 2019
LordKraken
left a comment
LordKraken
left a comment
There was a problem hiding this comment.
Thanks for fixing the min issue but changing the platform toolset forces us to upgrade to VS 2019.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added min function
Updated platform toolset for visual studio 2019