This repository was archived by the owner on Dec 4, 2025. It is now read-only.
Fixes for Fedora 43, Electron, Google sign in, GUI scaling - #39
Open
dewzor wants to merge 16 commits into
Open
Conversation
Updated the build script to apply the correct title bar fixes for Claude Desktop v0.14.10: - Changed titleBarStyle from "hidden" to "default" for native window controls - Set custom overlay bar height to 0 (e2=0) to remove white/yellow bar - Removed outdated main_window.tgz download (no longer needed) The variable names in the minified JavaScript changed in v0.14.10: - titleBarOverlay:Xi → show:Cpe||LG - (Sw|Tw|JC)=(pn|Er)?0:36 → e2=Er?0:36 This fix ensures users get native KDE/GNOME title bars without the awkward double title bar issue. Tested on Nobara Linux 42 (Fedora-based) with KDE Plasma. Related: bsneed#21
This commit adds several critical improvements to ensure Claude Desktop works properly on Fedora 41/42+ systems: ## Launcher Script Improvements (build-fedora.sh:387-412) **Added essential environment variables:** - GDK_BACKEND=x11 - Prevents GTK4 conflicts on Fedora 42+ - GTK_USE_PORTAL=0 - Disables portal for better compatibility - ELECTRON_DISABLE_SECURITY_WARNINGS=true - Cleaner output - QT_QPA_PLATFORM=xcb - Ensures Qt apps use X11 **Improved electron flags:** - Changed --ozone-platform-hint from 'auto' to 'x11' for stability - Added --disable-gpu-sandbox and --no-sandbox to avoid permission issues - Using absolute path /opt/electron/electron for app drawer compatibility These changes address issues reported in GitHub bsneed#21: - GTK version conflicts on Fedora 42+ - Launch failures from app drawer - Sandbox permission errors ## Title Bar Fix Validation (build-fedora.sh:241-269) **Added verification after each sed command:** - Checks if patterns were actually found and modified - Exits with clear error message if patterns have changed - Helps users identify version mismatches early This prevents silent failures where the build completes but the title bar fix doesn't actually apply. ## README Updates **Simplified installation instructions:** - Removed manual launcher script creation (now handled by build script) - Added "What's New" section highlighting v0.14.10 improvements - Clarified electron installation requirement - Added known issues section ## Testing All changes tested on: - Nobara Linux 42 (Fedora-based) with KDE Plasma - Claude Desktop v0.14.10 - Standalone Electron v37.0.0 Related: bsneed#21
Updated the build script to use Anthropic's official redirect API that always points to the latest Claude Desktop version: ## Changes **build-fedora.sh (lines 4-6):** - Changed from hardcoded Google Storage URL to official redirect API - URL: https://claude.ai/api/desktop/win32/x64/exe/latest/redirect - This automatically resolves to the latest Windows installer - Currently redirects to: Claude v1.0.332 (build b563c986) **README.md:** - Added "Auto-downloads latest version" to What's New section - Updated "Automatic Updates" section with clear explanation - Documented manual override option for specific versions - Users can still edit CLAUDE_DOWNLOAD_URL for testing/compatibility ## Benefits 1. **Always up-to-date**: No manual URL updates needed 2. **Official source**: Direct from Anthropic's servers 3. **Flexible**: Can still manually specify versions if needed 4. **Maintainable**: One less thing to track in the repo ## Testing Verified the redirect works: ```bash $ curl -sL "https://claude.ai/api/desktop/win32/x64/exe/latest/redirect" \ -o test.exe -w "HTTP: %{http_code}\n" HTTP: 200 ``` The download URL is now future-proof and requires no maintenance.
The redirect API URL was being blocked by Cloudflare's bot protection, resulting in an HTML challenge page instead of the actual installer. ## Problem When running build-fedora.sh, the download would fail with: ``` ERROR: Can not open the file as [PE] archive ``` Investigation showed the downloaded file was only 7KB and contained: ``` <!DOCTYPE html><html lang="en-US"><head><title>Just a moment...</title> ``` This is Cloudflare's challenge page for bot detection. ## Solution Added proper browser headers to the curl command: - User-Agent: Chrome 120 on Windows 10 - Accept headers for HTML content - Sec-Fetch-* headers to simulate browser navigation - -L flag to follow redirects Also added validation to detect if we downloaded an error page: - Checks file type with `file` command - Verifies it's a PE32 executable - Provides helpful error message if download fails ## Testing Verified the fix downloads the actual installer: ```bash $ file Claude-Setup-x64.exe Claude-Setup-x64.exe: PE32 executable for MS Windows (GUI) Intel i386 $ ls -lh Claude-Setup-x64.exe -rw-r--r-- 1 user user 120M nov 14 11:41 Claude-Setup-x64.exe ``` Download time: ~9 seconds on good connection File size: 120MB (correct for Claude Desktop installer) The build script should now work without manual intervention.
Updated the build script to apply the correct title bar fixes for Claude Desktop v0.14.10: - Changed titleBarStyle from "hidden" to "default" for native window controls - Set custom overlay bar height to 0 (e2=0) to remove white/yellow bar - Removed outdated main_window.tgz download (no longer needed) The variable names in the minified JavaScript changed in v0.14.10: - titleBarOverlay:Xi → show:Cpe||LG - (Sw|Tw|JC)=(pn|Er)?0:36 → e2=Er?0:36 This fix ensures users get native KDE/GNOME title bars without the awkward double title bar issue. Tested on Nobara Linux 42 (Fedora-based) with KDE Plasma. Related: bsneed#21
This commit adds several critical improvements to ensure Claude Desktop works properly on Fedora 41/42+ systems: **Added essential environment variables:** - GDK_BACKEND=x11 - Prevents GTK4 conflicts on Fedora 42+ - GTK_USE_PORTAL=0 - Disables portal for better compatibility - ELECTRON_DISABLE_SECURITY_WARNINGS=true - Cleaner output - QT_QPA_PLATFORM=xcb - Ensures Qt apps use X11 **Improved electron flags:** - Changed --ozone-platform-hint from 'auto' to 'x11' for stability - Added --disable-gpu-sandbox and --no-sandbox to avoid permission issues - Using absolute path /opt/electron/electron for app drawer compatibility These changes address issues reported in GitHub bsneed#21: - GTK version conflicts on Fedora 42+ - Launch failures from app drawer - Sandbox permission errors **Added verification after each sed command:** - Checks if patterns were actually found and modified - Exits with clear error message if patterns have changed - Helps users identify version mismatches early This prevents silent failures where the build completes but the title bar fix doesn't actually apply. **Simplified installation instructions:** - Removed manual launcher script creation (now handled by build script) - Added "What's New" section highlighting v0.14.10 improvements - Clarified electron installation requirement - Added known issues section All changes tested on: - Nobara Linux 42 (Fedora-based) with KDE Plasma - Claude Desktop v0.14.10 - Standalone Electron v37.0.0 Related: bsneed#21
Updated the build script to use Anthropic's official redirect API that always points to the latest Claude Desktop version: **build-fedora.sh (lines 4-6):** - Changed from hardcoded Google Storage URL to official redirect API - URL: https://claude.ai/api/desktop/win32/x64/exe/latest/redirect - This automatically resolves to the latest Windows installer - Currently redirects to: Claude v1.0.332 (build b563c986) **README.md:** - Added "Auto-downloads latest version" to What's New section - Updated "Automatic Updates" section with clear explanation - Documented manual override option for specific versions - Users can still edit CLAUDE_DOWNLOAD_URL for testing/compatibility 1. **Always up-to-date**: No manual URL updates needed 2. **Official source**: Direct from Anthropic's servers 3. **Flexible**: Can still manually specify versions if needed 4. **Maintainable**: One less thing to track in the repo Verified the redirect works: ```bash $ curl -sL "https://claude.ai/api/desktop/win32/x64/exe/latest/redirect" \ -o test.exe -w "HTTP: %{http_code}\n" HTTP: 200 ``` The download URL is now future-proof and requires no maintenance.
The redirect API URL was being blocked by Cloudflare's bot protection, resulting in an HTML challenge page instead of the actual installer. When running build-fedora.sh, the download would fail with: ``` ERROR: Can not open the file as [PE] archive ``` Investigation showed the downloaded file was only 7KB and contained: ``` <!DOCTYPE html><html lang="en-US"><head><title>Just a moment...</title> ``` This is Cloudflare's challenge page for bot detection. Added proper browser headers to the curl command: - User-Agent: Chrome 120 on Windows 10 - Accept headers for HTML content - Sec-Fetch-* headers to simulate browser navigation - -L flag to follow redirects Also added validation to detect if we downloaded an error page: - Checks file type with `file` command - Verifies it's a PE32 executable - Provides helpful error message if download fails Verified the fix downloads the actual installer: ```bash $ file Claude-Setup-x64.exe Claude-Setup-x64.exe: PE32 executable for MS Windows (GUI) Intel i386 $ ls -lh Claude-Setup-x64.exe -rw-r--r-- 1 user user 120M nov 14 11:41 Claude-Setup-x64.exe ``` Download time: ~9 seconds on good connection File size: 120MB (correct for Claude Desktop installer) The build script should now work without manual intervention.
Root cause: The previous v6 approach only HID titlebar elements with display:none, but the parent container still allocated CSS grid space for it, resulting in a visible dark gap. v7 Solution (hybrid approach from Gemini Pro/Flash consensus): - Layer 1: CSS grid-template-rows: 0 1fr to collapse first row - Layer 2: element.remove() instead of display:none - Layer 3: -webkit-app-region:drag detection (survives minification) - Simplified CSS file patching (main fixes via JS injection) Changes: - Replaced geometry-based hiding with DOM element removal - Added grid row collapse CSS as primary fix - Three-tier titlebar detection: app-region, class/id, geometry - MutationObserver catches React re-renders - Reduced CSS file patching (now just backup)
ROOT CAUSE IDENTIFIED: - Claude Desktop reserves 36px for titlebar via ternary patterns: - Main process: oR=hn?0:36 (36px on Linux, 0 on macOS) - Renderer: k1=Yu?0:36, C1=Yu?28:36 - v7 failed because it hid elements but didn't remove the space allocation v8 FIX: - Patch ?0:36 to ?0:0 via sed, eliminating gap at source - Simplified CSS backup with -36px negative margin - Removed complex DOM manipulation (no longer needed) - This fix survives minimize/restore as constants don't change at runtime
- Restructure README with install steps, feature overview, and FAQ - Update titlebar/MCP/Ctrl+Alt+Space docs to match current build - Add CHANGELOG covering recent versions
The patch `sed 's/titleBarOverlay:[^,}]*,//g'` is unsafe. Inside a bracket
expression `[^,}]` excludes only `,` and `}` — NOT `{` — so the match runs
greedily across object/function boundaries.
On the current Claude bundle (1.11187.4) `titleBarOverlay` also appears as a
function registration `titleBarOverlay:(A,e)=>{...}`. The regex eats
`titleBarOverlay:(A,` and leaves a dangling `},e)=>{...}`, turning index.js
into invalid JS. Electron then dies at load with
`SyntaxError: Unexpected token ':'` before any window opens — the app appears
to "start and do nothing".
It likely worked on the older build it was written for, where titleBarOverlay
only appeared as an object option. titleBarOverlay is a macOS/Windows-only
BrowserWindow option and is ignored on Linux when titleBarStyle is "default"
(which this script already sets), so it never needed stripping. Remove it.
Verified by replaying the build's edits on the pristine bundle:
WITH the titleBarOverlay sed -> node --check FAILS (Unexpected token ':')
WITHOUT it -> node --check OK
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…rrupts-bundle fix(build): remove blunt titleBarOverlay regex that corrupts index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes included:
Issues: