Fix SELRANGE in vf7_wrapper: move VLEN/64 guard to generate level#29
Open
Saksham05oct wants to merge 1 commit into
Open
Fix SELRANGE in vf7_wrapper: move VLEN/64 guard to generate level#29Saksham05oct wants to merge 1 commit into
vf7_wrapper: move VLEN/64 guard to generate level#29Saksham05oct wants to merge 1 commit into
Conversation
The GEN_VF7 genvar loop runs i over 0..(VLEN/32)-1, but the SEW_64 path sliced src_i[(i*64) +: 64], which is elaborated for every i and indexes outside src_i ([VLEN-1:0]) for i >= VLEN/64 (Verilator SELRANGE at i=2,3 under VLEN=128). Move the (i < VLEN/64) guard to a generate-level if so the 64-bit slice is only elaborated for valid lanes. The SEW_32 assignment is zero-extended explicitly to keep widths matched. Behaviour is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GEN_VF7 genvar loop runs i over 0..(VLEN/32)-1, but the SEW_64 path sliced src_i[(i*64) +: 64], which is elaborated for every i and indexes outside src_i ([VLEN-1:0]) for i >= VLEN/64 (Verilator SELRANGE at i=2,3 under VLEN=128). Move the (i < VLEN/64) guard to a generate-level if so the 64-bit slice is only elaborated for valid lanes. The SEW_32 assignment is zero-extended explicitly to keep widths matched. Behaviour is unchanged.