Fix veri_lint.sh: compile required packages and skip third-party sources#24
Open
Shivam-Shukla0 wants to merge 1 commit into
Open
Fix veri_lint.sh: compile required packages and skip third-party sources#24Shivam-Shukla0 wants to merge 1 commit into
Shivam-Shukla0 wants to merge 1 commit into
Conversation
drac_pkg.sv references fpnew_pkg (cvfpu) and several units import mmu_pkg, but veri_lint.sh only compiled riscv_pkg and drac_pkg, so 'make lint' failed on a fresh clone with PKGNODECL errors. This adds cf_math_pkg, fpnew_pkg and mmu_pkg to the compile line in dependency order, and excludes common_cells/cvfpu internal sources and their test files from the lint sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make lintfails on a fresh clone becauseveri_lint.shonly compilesriscv_pkg.svanddrac_pkg.sv, whiledrac_pkg.svreferencesfpnew_pkgand several units importmmu_pkg. The-Idirs don't help since packages need to be compiled, not just discoverable.Two changes:
cf_math_pkg,fpnew_pkgandmmu_pkgto the verilator invocation in dependency ordercommon_cells/cvfpu internal sources and theirtest/files from the file sweep — they are third-party libraries with their own CI, and some import packages (ecc_pkg, etc.) outside this repo's lint scopeVerified on Verilator 5.048 and 5.020:
PKGNODECL/Import package not founderrors go from hundreds to zero.Note: after this change the lint no longer stops on
PKGNODECL, but pre-existingWIDTHEXPAND/ASCRANGEwarnings inriscv_pkg/drac_pkg/fpnew_pkgnow surface. Those look like a separate issue and I've kept them out of scope here.Fixes #22