Update Three.js to 0.185.1 and use modern color management API - #218
Open
hexadecimal233 wants to merge 1 commit into
Open
Update Three.js to 0.185.1 and use modern color management API#218hexadecimal233 wants to merge 1 commit into
hexadecimal233 wants to merge 1 commit into
Conversation
|
@hexadecimal233 is attempting to deploy a commit to the Hacksore's Team Team on Vercel. A member of the Team first needs to authorize it. |
hexadecimal233
marked this pull request as ready for review
July 31, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to latest
three.js, but this may break some downstream repositories using the package usingthree.js1 without the viewer due tothree.js` version locking.Also consider splitting the core and the viewer modules (could be monorepo or so)?
Every
three.jsupdate can break the viewer (e.g. using r185 with the r156 current viewer) due toskinview3dis not a peer dependency, causing multiple three.js instances being loaded, splitting can increase the API compatibility and the usage flexibility.