Skip to content

fix #117 #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hacksore merged 3 commits into from
Feb 28, 2026
Merged

fix #117 #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d60e6d
fix part of #117
undefined303 Feb 25, 2026
51f1d96
fix #117
undefined303 Feb 25, 2026
1e79d6d
fix bug of previous code
undefined303 Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/viewer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
Scene,
Texture,
Vector2,
Vector3,
WebGLRenderer,
AmbientLight,
type Mapping,
Expand Down Expand Up @@ -328,6 +329,7 @@ export class SkinViewer {
private onDevicePixelRatioChange: () => void;

private _nameTag: NameTagObject | null = null;
private nameTagYOffset: number = 20;

constructor(options: SkinViewerOptions = {}) {
this.canvas = options.canvas === undefined ? document.createElement("canvas") : options.canvas;
Expand Down Expand Up @@ -562,6 +564,10 @@ export class SkinViewer {
this.recreateEarsTexture();
if (options.ears === true) {
this.playerObject.ears.visible = true;
if (this._nameTag) {
this.nameTagYOffset = 25;
this._nameTag.position.y = this.nameTagYOffset;
}
}
}
} else {
Expand Down Expand Up @@ -628,6 +634,10 @@ export class SkinViewer {

if (options.makeVisible !== false) {
this.playerObject.ears.visible = true;
if (this._nameTag) {
this.nameTagYOffset = 25;
this._nameTag.position.y = this.nameTagYOffset;
}
}
} else {
return loadImage(source).then(image => this.loadEars(image, options));
Expand All @@ -636,6 +646,10 @@ export class SkinViewer {

resetEars(): void {
this.playerObject.ears.visible = false;
if (this._nameTag) {
this.nameTagYOffset = 20;
this._nameTag.position.y = this.nameTagYOffset;
}
this.playerObject.ears.map = null;
if (this.earsTexture !== null) {
this.earsTexture.dispose();
Expand Down Expand Up @@ -668,11 +682,14 @@ export class SkinViewer {
return loadImage(source).then(image => this.loadBackground(image, mapping));
}
}

private draw(): void {
const dt = this.clock.getDelta();
if (this._animation !== null) {
this._animation.update(this.playerObject, dt);
if (this._nameTag) {
this._nameTag.position.y =
this.playerObject.skin.head.getWorldPosition(new Vector3()).y + this.nameTagYOffset - 8;
}
}
if (this.autoRotate) {
if (!(this.controls.enableRotate && this.isUserRotating)) {
Expand Down Expand Up @@ -863,6 +880,9 @@ export class SkinViewer {
this.playerObject.resetJoints();
this.playerObject.position.set(0, 0, 0);
this.playerObject.rotation.set(0, 0, 0);
if (this._nameTag) {
this._nameTag.position.y = this.nameTagYOffset;
}
this.clock.stop();
this.clock.autoStart = true;
}
Expand Down Expand Up @@ -903,7 +923,8 @@ export class SkinViewer {
// Add the new name tag to the scene
this.playerWrapper.add(newVal);
// Set y position
newVal.position.y = 20;
this.nameTagYOffset = this.playerObject.ears.visible ? 25 : 20;
newVal.position.y = this.nameTagYOffset;
}

this._nameTag = newVal;
Expand Down