Skip to content

Block DC, fix label and remove duplicate code in gx_distortion - #273

Open
chy-causer wants to merge 2 commits into
brummer10:masterfrom
chy-causer:master
Open

Block DC, fix label and remove duplicate code in gx_distortion#273
chy-causer wants to merge 2 commits into
brummer10:masterfrom
chy-causer:master

Conversation

@chy-causer

Copy link
Copy Markdown

Hi there,

As the title says, this patch concerns the gx_distortion, or Multi Band Distortion module:

  1. Before this patch, when changing the offset, DC is output. By switching to cubicnl_nodc this is fixed.
  2. There is smoothing on the slider now, to remove the clicks when changing the offset.
  3. The offset was, I think, incorrectly labelled as level. I have kept the slider name "level" so as people's saved settings are preserved, but now the panel displays "Offset", with a tooltip which I copied from another module.
  4. There was some redundant code as I suspect the minimum requirement for Faust has been bumped.

Speaking of Faust version, the generated code has been generated with FAUST Version 2.81.10, as packaged by Ubuntu for 26.04.

I have not touched distortion.dsp, which seems to have similar issues, but I suspect may be dead code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant