Fix Windows console crashes, portrait rotation detection, and timeline_view seek edge case; add CRF/preset overrides - #112
Open
sameer99z wants to merge 1 commit into
Open
Conversation
…e_view seek edge case; add CRF/preset overrides - ASCII-only print output in transcribe_batch.py, render.py, grade.py, pack_transcripts.py to avoid crashes on the default Windows cp1252 console - render.py: read rotation side-data and swap w/h when detecting portrait sources, fixing WhatsApp/phone clips with +/-90deg rotation metadata being misclassified as landscape and cropped to the wrong canvas - render.py: add --crf/--preset CLI overrides for higher-quality renders - timeline_view.py: pull the final sample frame back ~0.05s so it doesn't land past the container's last frame timestamp and fail the ffmpeg seek - add uv.lock
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="helpers/render.py">
<violation number="1" location="helpers/render.py:663">
P2: `--crf` and `--preset` are ignored for renders that composite overlays or subtitles: `build_final_composite` re-encodes with hard-coded `fast`/`18`. Thread both overrides into that final pass so CLI quality settings apply to the delivered file.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| segment_paths = extract_all_segments( | ||
| edl, edit_dir, preview=args.preview, draft=args.draft | ||
| edl, edit_dir, preview=args.preview, draft=args.draft, | ||
| crf_override=args.crf, preset_override=args.preset, |
There was a problem hiding this comment.
P2: --crf and --preset are ignored for renders that composite overlays or subtitles: build_final_composite re-encodes with hard-coded fast/18. Thread both overrides into that final pass so CLI quality settings apply to the delivered file.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At helpers/render.py, line 663:
<comment>`--crf` and `--preset` are ignored for renders that composite overlays or subtitles: `build_final_composite` re-encodes with hard-coded `fast`/`18`. Thread both overrides into that final pass so CLI quality settings apply to the delivered file.</comment>
<file context>
@@ -613,10 +659,11 @@ def main() -> None:
segment_paths = extract_all_segments(
- edl, edit_dir, preview=args.preview, draft=args.draft
+ edl, edit_dir, preview=args.preview, draft=args.draft,
+ crf_override=args.crf, preset_override=args.preset,
)
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes Windows console crashes and incorrect portrait handling for phone clips, and makes timeline seek more reliable. Adds
--crf/--presetoverrides for quality control and includesuv.lock.Bug Fixes
New Features
render.py: add--crfand--presetflags to override the default quality ladder.uv.lock.Written for commit 9611e36. Summary will update on new commits.