Repository navigation
Conversation
Add a public EventBus.remove(event_pattern, handler) method so callers can unsubscribe a handler registered with EventBus.on(). Returns True if the handler was found and removed, False otherwise. Extract event-key resolution from on() into _get_event_key() and reuse it in on() and remove(), and refactor expect() cleanup to use remove(). Co-Authored-By: Claude Code <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a public
EventBus.remove(event_pattern, handler)method so callers can unsubscribe a handler registered withEventBus.on(). ReturnsTrueif the handler was found and removed,Falseotherwise.Also extract the event-key resolution from
on()into_get_event_key()and reuse it inon()andremove(), and refactorexpect()cleanup to useremove().Why
There is no way to unsubscribe after
EventBus.on()— the only cleanup path isexpect()'s internalself.handlers[...].remove(...). Closes #5.How tested
tests/test_remove_handler.py(4 cases: by class, by string name, scoped removal, wildcard*).🤖 Generated with Claude Code
Summary by cubic
Adds
EventBus.remove()to unsubscribe a handler registered withEventBus.on(). ReturnsTrueif the handler was found and removed,Falseotherwise. Closes #5.Changes
_get_event_key()and reuses it inon(),remove(), andexpect()cleanup.on()so typed handlers remain valid when removed, and drops the event key from the registry once its last handler is gone.*wildcard.Written for commit af4fb71. Summary will update on new commits.