Fix set tags transaction#32
Merged
Merged
Conversation
The set command resolved tag names to project PHIDs but never added them to the edit params, so phable set --tags sent a maniphest.edit request with no projects transaction Add the resolved PHIDs as a projects.add transaction, matching the non-destructive behavior used by task creation Clarify the --tags help text so callers know it appends project tags rather than replacing the existing set Assisted-by: GPT-5.5 & Claude Opus 4.8
ryankemper
force-pushed
the
fix-set-tags-transaction
branch
from
4479486 to
80d9544
Compare
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The set command resolved tag names to project PHIDs but never added them to the edit params, so
phable set --tagssent amaniphest.editrequest with no projects transactionAdd the resolved PHIDs as a projects.add transaction, matching the non-destructive behavior used by task creation
Also clarify the
--tagshelp text so callers know it appends project tags rather than replacing the existing set