fix(http): enable livestream for T8426 dual-lens floodlight cameras#949
Open
qike-ms wants to merge 1 commit into
Open
fix(http): enable livestream for T8426 dual-lens floodlight cameras#949qike-ms wants to merge 1 commit into
qike-ms wants to merge 1 commit into
Conversation
The T8426 (FLOODLIGHT_CAMERA_8426, device type 87) is recognised as a
floodlight (isFloodLight(87) === true) but, not matching any earlier
branch in startLivestream(), it fell through to the generic floodlight
branch (CMD_DOORBELL_SET_PAYLOAD "(3)") whose payload omits camera_type
and entrytype. With that payload the camera never sends any media and the
P2P session times out after 5s ("rtsp livestream stopped") with zero bytes.
Its sibling T8425 uses the richer branch "(1)" payload
(camera_type: 0, entrytype: 0, accountId) and streams fine. Routing the
T8426 into the same branch makes it stream as well.
Verified on 4x T8426 (sw 1.2.1.0): both lenses start (1920x1080 +
2560x1440 H264) with ~1.3 MB video + audio in ~18s; previously 0 bytes.
Adds an instance isFloodLightT8426() helper (mirroring isFloodLightT8425)
and includes it in the branch-1 condition.
Author
|
Friendly ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #948 — the T8426 dual-lens floodlight camera (
FLOODLIGHT_CAMERA_8426,device type 87) never streams:
startLivestream()resolves but the camera sendsno media and the P2P session times out after 5s with zero bytes.
Root cause: the T8426 is a floodlight (
isFloodLight(87) === true) but matchesno earlier branch in
startLivestream(), so it falls through to the genericfloodlight branch ("CMD_DOORBELL_SET_PAYLOAD (3)"), whose payload omits
camera_type/entrytype. Its sibling T8425 uses the richer branch "(1)"payload (
camera_type: 0,entrytype: 0,accountId) and works. This routesthe T8426 through the same branch.
Change
device.ts: add instance helperisFloodLightT8426()(mirrorsisFloodLightT8425(); the staticDevice.isFloodLightT8426()already existed).station.ts: includedevice.isFloodLightT8426()in the branch-1 condition ofstartLivestream().} else if ( device.isOutdoorPanAndTiltCamera() || device.isFloodLightT8425() || + device.isFloodLightT8426() || (device.isBatteryDoorbellDualE340() && !this.isStationMiniBaseChime()) || ((device.isIndoorPTCameraE30() || device.isIndoorCameraBase()) && this.isDeviceControlledByHomeBase()) ) {Verification
Tested on 4× T8426 (sw
1.2.1.0). Before: 0 bytes + 5s timeout. After: allfour start both lenses (
1920x1080+2560x1440H264), ~1.3 MB video +~53 KB audio in ~18s, first bytes
00000001 67 …(valid H264 SPS). Live 1080pplayback confirmed end-to-end.
npm run build:ts— cleannpx prettier --check src/http/station.ts src/http/device.ts— cleanNotes
I understand the library is in stopgap/deprecation mode; this is a minimal
one-line routing fix so these cameras keep working on the current backend. No
behavioural change for any other device.