Skip to content

fix(outdoor-pt): restore S340 (T8170) disable→app sync broken by #873 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephanevalk wants to merge 1 commit into from
Closed

fix(outdoor-pt): restore S340 (T8170) disable→app sync broken by #873 #919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions src/http/station.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7443,12 +7443,28 @@ export class Station extends TypedEmitter<StationEvents> {
}
);
} else if (device.isOutdoorPanAndTiltCamera()) {
// Outdoor pan/tilt cams (eufyCam S4 / T8172 etc.) behind a HomeBase 3
// silently drop raw CMD_DEVS_SWITCH frames. Pcap comparison against
// the iOS Eufy app shows they accept the same wrapped envelope as
// INDOOR_PT_CAMERA_S350 — outer CMD_SET_PAYLOAD carrying inner
// CMD_INDOOR_ENABLE_PRIVACY_MODE_S350.
// Outdoor pan/tilt cams (type 48) cover both the S340 (T8170) and the
// S4 (T8172). They behave differently:
// - S340: uses the legacy CMD_DEVS_SWITCH (1035) on/off path. The HB3
// processes this raw command, updates param 1035 in the cloud, and
// pushes the change to the Eufy app (so the app reflects it live).
// - S4: only reacts to the wrapped CMD_INDOOR_ENABLE_PRIVACY_MODE_S350
// (6250) envelope (see #710 / #873); it ignores raw 1035 frames.
// Sending both keeps both models working: each cam acts on the command
// it understands and ignores the other.
param_value = value === true ? 0 : 1;
this.p2pSession.sendCommandWithIntString(
{
commandType: CommandType.CMD_DEVS_SWITCH,
value: param_value,
valueSub: device.getChannel(),
strValue: this.rawStation.member.admin_user_id,
channel: device.getChannel(),
},
{
property: propertyData,
}
);
this.p2pSession.sendCommandWithStringPayload(
{
commandType: CommandType.CMD_SET_PAYLOAD,
Expand Down
3 changes: 3 additions & 0 deletions src/http/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7131,6 +7131,9 @@ export const DeviceProperties: Properties = {
...GenericDeviceProperties,
[PropertyName.DeviceWifiRSSI]: DeviceWifiRSSIProperty,
[PropertyName.DeviceWifiSignalLevel]: DeviceWifiSignalLevelProperty,
// S340 exposes its on/off state via the legacy CMD_DEVS_SWITCH (1035) param,
// which is what the Eufy mobile app reads and writes. (The S4/T8172 uses the
// wrapped 6250 privacy param instead.)
[PropertyName.DeviceEnabled]: DeviceEnabledSoloProperty,
[PropertyName.DeviceBattery]: DeviceBatteryProperty,
[PropertyName.DeviceBatteryTemp]: DeviceBatteryTempProperty,
Expand Down
Loading