fix(tft): responsive scorecard grid + accessible, scrollable backtest tables - #14
Open
brooksRoley wants to merge 1 commit into
Open
fix(tft): responsive scorecard grid + accessible, scrollable backtest tables#14brooksRoley wants to merge 1 commit into
brooksRoley wants to merge 1 commit into
Conversation
… tables The TFT case-study section on /basketball-platform (Brooks's top job-relevance page for the Lakers application) shipped with 3 UX bugs flagged by PM/UXR and CEO reviews but never fixed before merge: a fixed 3-column scorecard grid with no mobile breakpoint (every other grid on the page uses sm:/lg: variants), and two backtest tables with no horizontal-scroll wrapper plus sort headers that were bare clickable <th> elements — not real buttons, no aria-sort, no keyboard operability (WCAG 2.1.1 gap). Also adds the first test coverage for both table components (previously zero). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014dwH6op8ZmPEA9by6UvjU9
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/basketball-platformresponsive (grid-cols-1 sm:grid-cols-3instead of a bare fixed 3-col grid that cramped on mobile)TeamResidualsTable,CoefficientsTable) inoverflow-x-autoso they no longer overflow the viewport on narrow screensTeamResidualsTable's sortable column headers from bare clickable<th>elements into real, keyboard-operable<button>s witharia-sort— fixes a WCAG 2.1.1 (keyboard) gapLivelihood stream
This section of
/basketball-platformis Brooks's primary case study for the LA Lakers Software Developer - Basketball Data Strategy application. These 2 UX bugs shipped to production unfixed with PR #10 (2026-07-21) and sat flagged on the cross-session recommendations ledger for 5 days — this closes them out.Why
Two concrete, previously-flagged bugs on the site's single highest job-relevance page: a non-responsive grid that cramps on mobile, and backtest tables that were neither scrollable on narrow screens nor operable by keyboard. Small, self-contained, zero new dependencies or secrets.
Files changed
src/pages/basketball-platform.jsx— responsive scorecard gridsrc/components/tft/TeamResidualsTable.tsx— scroll wrapper + accessible sort buttonssrc/components/tft/CoefficientsTable.tsx— scroll wrappersrc/components/tft/__tests__/TeamResidualsTable.test.tsx(new)src/components/tft/__tests__/CoefficientsTable.test.tsx(new)Test steps
yarn dev, visit/basketball-platform, scroll to the TFT Backtest section (requirestft_coefficientsto be activated in your DB, or view the responsive grid/table markup directly in the diff)sm:, and both tables scroll horizontally instead of overflowing<button>, focus-visible ring shows, Enter/Space triggers sort,aria-sortreflects the active columnReal command output, cold sandbox:
(Test count was 589/589 before this PR — this branch adds 6 new component tests.)
Agent checklist
yarn buildpasses locallyyarn testpasses (no regressions to game logic) — 595/595TODO, placeholder, or stub code.envvalues committedog:title,og:description,og:image,twitter:card— N/A, no new pagesPreText,Reveal,TiltCardused for any new UI text/cards — N/A, no new UI text/cards, only fixing existing table/grid markupLearn
Daily agent routine — Staff Engineer role (day-of-year 206 % 7 = 3). Picked directly off the cross-session recommendations ledger, which called this "a good next Staff-Eng/Design pickup — small, agent-doable, no secrets" after 2 prior sessions confirmed it live in production and unfixed.
Generated by Claude Code