Do not report aws_log_type tag if missing from destination config - #42
Merged
Conversation
bgaudin-lc
force-pushed
the
BRONTO-2026
branch
from
October 14, 2025 22:21
5cbfc4f to
53dad64
Compare
mcgauranc
approved these changes
Oct 14, 2025
marcoaquilanti
approved these changes
Oct 15, 2025
jcolgan-bronto
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_collection_typeis renamedget_source_typeas the current fct name is misleading with regard to Bronto collections, which it does not relate to.aws_log_typetag rather than failing for the S3 source type, if log_type is not present in the config.