Macos - #2
Open
brokkoli71 wants to merge 5 commits into
Open
Conversation
- Detect dark/light mode and accent colour via `defaults read` in _load_theme() (runs first, before Omarchy/GNOME/KDE blocks) - Add macos/ folder: install.md, Brewfile, and build_app.sh starter for PyInstaller .app bundles - Add macOS CI job (macos-latest / Apple Silicon) to ci.yml - Add TestMacOSTheme (8 tests) to test_pdfeditor.py; all mocked so they run on Linux CI too Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The offscreen backend is Linux-only. macOS GitHub Actions runners have a Quartz window server, so GTK can use its default backend there. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
On darwin _load_theme() takes the macOS branch before reaching the TOML reader, so mock sys.platform="linux" to exercise the TOML code path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.