TSPS-1127 make all disk sizes dynamic and set bootDiskSizeGb to 0 for all tasks - #1925
Open
jsotobroad wants to merge 4 commits into
Open
TSPS-1127 make all disk sizes dynamic and set bootDiskSizeGb to 0 for all tasks#1925jsotobroad wants to merge 4 commits into
jsotobroad wants to merge 4 commits into
Conversation
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Remember to squash merge! |
🔍Changelog Validation Results: |
🔍Version Validation Results: |
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
|
Remember to squash merge! |
🔍Version Validation Results: |
🔍Changelog Validation Results: |
jsotobroad
commented
Aug 15, 2026
| } | ||
|
|
||
| Int disk_size_gb = ceil(size(input_vcf, "GiB") + size(panel_split_chunk_bin, "GiB") + size(genetic_map, "GiB") + 30) | ||
| Int disk_size_gb = ceil(size(input_vcf, "GiB") + size(panel_split_chunk_bin, "GiB") + size(genetic_map, "GiB") + 40) |
Contributor
Author
There was a problem hiding this comment.
this change was to help with the batch size testing, this will need to change when we scale test as well so just tryign to help with that now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want to make sure all of tasks have dynamic disk sizing
We also are testing whether we can set bootDiskSizeGb to 0.
Non call cached submission with these changes - https://app.terra.bio/#workspaces/allofus-drc-imputation/aou_sv_imputation_tsps_testing/submission_history/a37941e9-eb48-4ab9-981a-9596f88b1565
jira ticket - https://broadworkbench.atlassian.net/browse/TSPS-1127
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.