Repository navigation
CTM-604: bump workbench-libs, which bumps swagger-ui - #3569
Merged
Merged
Conversation
4 of 9 tasks
davidangb
commented
Jul 28, 2026
| val bigQueryService = mock[GoogleBigQueryService[IO]](RETURNS_SMART_NULLS) | ||
| val job = mock[Job] | ||
| when(job.getQueryResults(any())).thenReturn(createTableResult(data)) | ||
| when(job.getQueryResults()).thenReturn(createTableResult(data)) |
Contributor
Author
There was a problem hiding this comment.
the workbench-libs updates also carry a mockito update. This is a necessary change to be compatible with the new mockito.
The runtime code calls getQueryResults() with no arguments. The previous version of mockito matched a no-arg call to an any() call. The newer version of mockito does not match on any(), so these mocks were no longer valid and the tests failed. I'm updating the tests to be more accurate to the runtime call.
davidangb
commented
Jul 28, 2026
| val googleApiUri = Uri.unsafeFromString(gcsConfig.getString("google-api-uri")) | ||
| val metadataNotificationConfig = NotificationCreaterConfig(pathToCredentialJson, googleApiUri) | ||
| BlazeClientBuilder[F].withExecutionContext(executionContext).resource.flatMap { httpClient => | ||
| EmberClientBuilder.default[F].build.flatMap { httpClient => |
Contributor
Author
There was a problem hiding this comment.
the workbench-libs updates also carry an http4s update. The newer http4s uses EmberClient instead of BlazeClient, so this needs a compatibility fix. The compatibility fix carries over into Boot.scala too.
davidangb
marked this pull request as ready for review
July 28, 2026 18:10
marctalbott
approved these changes
Jul 28, 2026
jgainerdewar
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CTM-604
CTM-601
Bumps to latest version of workbench-libs' oauth2, to take advantage of its bump of swagger-ui. See broadinstitute/workbench-libs#1753.
Net effect is that the swagger-ui used by Rawls goes from
5.17.14to5.32.11. which satisfies https://broadworkbench.atlassian.net/browse/CTM-601.