Skip to content

CTM-548 Exclude Azure, AWS dependencies - #3567

Merged
aednichols merged 6 commits into
developfrom
aen_ctm_548
Jul 13, 2026
Merged

aednichols merged 6 commits into
developfrom
aen_ctm_548

Conversation

@aednichols

Copy link
Copy Markdown
Contributor

Story objective: the netty-resolver version has a vuln, update or remove.

Resolution:

The app was actually very close to completely removing com.azure.* dependencies, this PR finishes the job.

We have been on a treadmill of updating overrides on deps that TCL pulls in, and that should now stop.

As a bonus, we were getting some AWS stuff from the Kubernetes part of TCL, so go ahead and exclude that too.

Testing:

  1. Static inspection: the config key azureIdentity has zero occurrences in terra-helmfile
  2. Will smoke test after deploying to Dev

Before:

sbt -mem 8192 "whatDependsOn io.netty netty-resolver"

io.netty:netty-resolver:4.1.126.Final (evicted by: 4.1.133.Final)
[info]   +-software.amazon.awssdk:netty-nio-client:2.33.13
[info]     +-software.amazon.awssdk:sts:2.33.13
[info]       +-io.kubernetes:client-java:25.0.0
[info]         +-bio.terra:terra-common-lib:1.1.70-SNAPSHOT
[info]         | +-org.broadinstitute.dsde:rawls-core_2.13:6527b9312-SNAP [S]

[info] io.netty:netty-resolver:4.1.127.Final (evicted by: 4.1.133.Final)
[info]   +-io.netty:netty-resolver-dns:4.1.127.Final
[info]     +-io.netty:netty-resolver-dns-classes-macos:4.1.127.Final
[info]     | +-io.netty:netty-resolver-dns-native-macos:4.1.127.Final
[info]     |   +-io.projectreactor.netty:reactor-netty-core:1.2.10
[info]     |   | +-io.projectreactor.netty:reactor-netty-http:1.2.10
[info]     |   |   +-com.azure:azure-core-http-netty:1.16.2
[info]     |   |     +-com.azure:azure-identity:1.18.1
[info]     |   |     | +-bio.terra:stairway-azure:1.1.60-SNAPSHOT
[info]     |   |     | | +-bio.terra:terra-common-lib:1.1.70-SNAPSHOT
[info]     |   |     | |   +-org.broadinstitute.dsde:rawls-core_2.13:6527b9312-SNAP [S]

After:

sbt -mem 8192 "whatDependsOn io.netty netty-resolver"

<crickets>

@aednichols
aednichols requested a review from a team as a code owner July 13, 2026 17:53
@aednichols
aednichols requested review from calypsomatic and removed request for a team July 13, 2026 17:53

@davidangb davidangb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this!

val excludeAkkaActor = ExclusionRule(organization = "com.typesafe.akka", name = "akka-actor_2.12")
val excludeAkkaStream = ExclusionRule(organization = "com.typesafe.akka", name = "akka-stream_2.12")

val excludePostgresql = ExclusionRule("org.postgresql", "postgresql")

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved in-line to the location of its only reference


val circeYAML: ModuleID = "io.circe" %% "circe-yaml" % "1.15.0"

val azureIdentity: ModuleID = "com.azure" % "azure-identity" % "1.18.1"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed outright 🚀

@aednichols
aednichols enabled auto-merge (squash) July 13, 2026 21:04
@aednichols
aednichols merged commit c0b00b4 into develop Jul 13, 2026
24 checks passed
@aednichols
aednichols deleted the aen_ctm_548 branch July 13, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants