Add filter_meta_array and change filter_arrays_by_meta to support more complex items_to_filter parameters by using filter_meta_array - #725
Open
jkgoodrich wants to merge 18 commits into
Conversation
klaricch
requested changes
Aug 22, 2024
… into jg/add_functionality_to_filter_arrays_by_meta
This was referenced Aug 29, 2024
klaricch
requested changes
Sep 10, 2024
| only_group = [{"group": "adj"}, {"group": "raw"}] | ||
| group_gen_anc_a = [{"group": "adj", "gen_anc": "a"}] | ||
| group_gen_anc_a_b = [*group_gen_anc_a, {"group": "adj", "gen_anc": "b"}] | ||
| group_gen_anc = [*group_gen_anc_a_b, {"group": "adj", "gen_anc": "c"}] |
Contributor
There was a problem hiding this comment.
should this one be named "group_gen_anc_a_b_c" ?
Contributor
There was a problem hiding this comment.
after reading through, maybe just add a comment here to clarify since it breaks the pattern
| group_sex = [{"group": "adj", "sex": "XX"}, {"group": "adj", "sex": "XY"}] | ||
| group_subset = [ | ||
| {"group": "adj", "subset": "s1"}, | ||
| {"group": "raw", "subset": "s1"}, |
Contributor
There was a problem hiding this comment.
just following the patterns of the others, should this actually be {"group": "adj", "subset": "s2"}?
Contributor
There was a problem hiding this comment.
or add comment to clarify
| {"group": "adj", "gen_anc": "b", "sex": "XY"}, | ||
| ] | ||
| group_gen_anc_a_b_sex = group_gen_anc_a_sex + group_gen_anc_b_sex | ||
| group_gen_anc_sex = [ |
| *group_gen_anc_a_subset, | ||
| {"group": "adj", "gen_anc": "b", "subset": "s1"}, | ||
| ] | ||
| group_gen_anc_subset = [ |
Contributor
There was a problem hiding this comment.
group_gen_anc_a_b_c_subset?
| group_gen_anc_a_b_sex_subset = ( | ||
| group_gen_anc_a_sex_subset + group_gen_anc_b_sex_subset | ||
| ) | ||
| group_gen_anc_sex_subset = [ |
Contributor
There was a problem hiding this comment.
group_gen_anc_a_b_c_sex_subset
| combine_operator: str, | ||
| exact_match: bool, | ||
| expected: str, | ||
| metadata_combinations: Any, |
Contributor
There was a problem hiding this comment.
what does metadata_combinations refer to?
| expected_meta: List[Dict[str, str]], | ||
| expected_expr1: List[int], | ||
| expected_expr2: List[int], | ||
| ) -> None: |
| (s_ga_list, False, *all_and, False, "no_sex_and_no_gen_anc"), | ||
| (s_ga_ex, True, *all_and, False, "no_sex_and_no_gen_anc"), | ||
| (["sex", "subset"], True, "or", "and", "and", False, "sex_or_subset"), | ||
| (ss_d_list, False, *all_and, False, "no_subset_and_no_downsampling"), |
Contributor
There was a problem hiding this comment.
should only exclude if both subset and downsampling are present?
| exact_match: bool, | ||
| expected_meta: str, | ||
| metadata_combinations: Any, | ||
| ) -> None: |
| filtering criteria for keys/key-value pairs to exclude. | ||
| :param combine_operator: Whether to use "and" or "or" to combine the keep and | ||
| exclude filtering criteria. | ||
| :param exact_match: Whether to apply the filtering only to items with exactly the |
Contributor
There was a problem hiding this comment.
clarify that this only relates to the "keep" items
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I still need to add tests for the added function and modified function