Allow CELL and NBHD layers to be visible together - #295
Open
jaspreetishar wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
js/ui/text_buttons.jsthat forced the NBHD layer off when the CELL button was turned on so CELL toggling no longer disables NBHD visibility.viz_nbhd_layersubscription injs/viz/landscape_ist.jsto stop auto-disabling or re-enabling the CELL layer, CELL slider, and CELL button state when NBHD visibility changes, making NBHD visibility independent of CELL.new_toggle_cell_layer_visibilityimport fromjs/viz/landscape_ist.jsas a cleanup after decoupling NBHD/CELL behavior.Testing
npm run lint:js(ESLint) and it completed successfully.Codex Task