Nbhd color values - #291
Draft
cornhundred wants to merge 11 commits into
Draft
Conversation
# Conflicts: # js/deck-gl/layers/nbhd_layer.js # js/global_variables/selected_genes.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #291: Neighborhood Attribute Coloring & Enrichment Linking Improvements
Summary
This PR adds support for coloring neighborhoods by numerical attributes (gene expression, GDF properties) and improves the Clustergram-Enrich widget linking using jslink for more reliable communication.
New Features
🎨 Neighborhood Attribute Coloring
New
nbhd_adataparameter on Landscape: Pass an AnnData with neighborhoods as obs and attributes (genes, populations, etc.) as varDropdown for GDF attributes: Numeric columns from neighborhood GeoDataFrame are now available in a color dropdown (e.g.,
area,perimeter)nbhd_geneentity type: New entity type for Clustergrams where rows are genes aggregated at the neighborhood leveldata_typefield in AxisEntity: Allows specifying the underlying data type for analysis purposes, independent of the spatial entity🔗 Simplified Clustergram-Enrich Linking
Replaced Python observers with jslink: More reliable trait synchronization that works even when Python kernel restarts
Removed
link_clustergram_to_enrichfunction: No longer needed since jslink handles the connectionSimplified API: Removed
row_enrich/col_enrichparameters (jslink syncs all selected genes)Bug Fixes
Files Changed
src/celldega/viz/widget.pynbhd_adataparameter, attribute request/response traitletssrc/celldega/viz/__init__.pysrc/celldega/clust/constants.pydata_typefield andnbhd_geneentityjs/ui/nbhd_attr_dropdown.jsjs/deck-gl/layers/nbhd_layer.jsjs/widget_interactions/update_ist_landscape_from_cgm.jsnbhd_geneandnbhd_varentitiesUsage Example