Implement vgoto - #1559
Draft
bi4k8 wants to merge 3 commits into
Draft
Implement vgoto#1559bi4k8 wants to merge 3 commits into
bi4k8 wants to merge 3 commits into
Conversation
otherwise, one must explicitly goto a "magic" offset to match the position of the first text conky renders
Co-authored-by: easysid <easysid+github@gmail.com>
✅ Deploy Preview for conkyweb ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
3 tasks
Collaborator
|
Just letting you know that node kinds (variables) now use an |
|
Anything we can do to help get this merged? |
Collaborator
If you have development experience you could debug and try fixing the mentioned problem. Besides that, this branch needs to be fast forwarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription
This implements a vertical
goto, to match the existing horizontal one. This has been requested by a number of users. Closes #450, and is based in part on the patch there by @easysid.Tested against the following conkyrc:
This is still a draft because it seems to cause some issues calculating height--with the above conkyrc, on the first iteration, everything looks as expected, but at the beginning of the second iteration, the whole displayed output moves downward, and the bottom line gets cut off. I'll have to debug what's happening there. I have seen similar jumps previously, so it seems more likely that this is exacerbating an existing misbehavior than introducing a completely new one.