Swap print() call in dataset.py with logger.info()#72
Merged
hansmohrmann merged 1 commit intoApr 22, 2026
Conversation
hansmohrmann
approved these changes
Apr 22, 2026
hansmohrmann
left a comment
Collaborator
There was a problem hiding this comment.
Hi Tim! Apologies for the late reply. yes absolutely, this is better.
Contributor
Author
|
Awesome, thanks @hansmohrmann! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks! First off, many thanks for this amazing resource. I have created a workflow for comparing forecast models directly against observations, and I've found the nnja-ai datasets and API to be incredibly useful. Hats off to you all 👏
This PR is just a micro suggestion, so let me know what you think. Right now, every time a dataset gets loaded we get a print statement like:
Is there any reason this is a print statement? When I run this for example using SLURM, it results in these print statements coming at the end of the job and in a different location from the rest of the nnja_ai logging, since they're not piped in the same way as the logger. Because of that, the statements are not really useful progress markers. I think it would be nice to get these with the rest of the logs, hence the PR.
Let me know what you think! Thanks again for this awesome package!