fix add-on export hanging forever on compile errors#1655
Open
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN wants to merge 2 commits into
Open
Conversation
|
|
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN
force-pushed
the
fix/export-error-report-failure
branch
from
bdbdb6d to
e94e31d
Compare
Member
|
Related to #1640 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the exporting hits a compile error, the dash worker throws an error in
dash.build(), but this error never gets posted. So the main thread just waits forever and the progress notification is also never cleared. (actual error is swallowed and i thinkdash.dispose()was never really called, so I moved it in a finally block)Motivation
#1652
Additional Context
none needed