Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4849
The snapshot owns copies of what its loaded project keeps past
project_open: the artifact, target and profile strings (aProjKey, shared with the loaded-project path throughproj_key_captureandproj_key_free, which now take an allocator) and the root.driver.begin_build_implsetsp.req.project_root = project_root, androot_analyzesetsrooted.project_root = root, so the project held the caller'sreq.root. The request is now built from the copies, all freed inproject_dnit. The buffer array and buffer paths stay borrowed only during the call.Ran: bootstrap.sh build,
mach check .andmach fmt --check .clean. No new tests.Decisions
keyis a privateProjKeyandroota plain ownedstrbeside it. The loaded-project path already owns its root separately, so the root is not folded intoProjKey. No new pub declaration.project_openbefore the load and freed inproject_dnitafter the project.