Repository navigation
chore: the library artifact is exported - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On mach dev a bare
use <id>;binds only the library artifact markedexport = true, anddefault = trueno longer implies it. Without it a dependent'suse json;fails withuse.no_public_module, which this package's own CI cannot see because a package never bare-imports itself. The same mark is what lets the library's requirements travel to consumers.Decisions
export = truegoes on[artifact.json], the only library artifact, right afterdefault = true.Ran
A throwaway consumer outside the repo with
[dep.json]by path and a bareuse json;. It fails name resolution withuse.no_public_moduleon dev and resolves with this change.mach build . --allon the package passes.