Repository navigation
Conversation
the router's decoders serve path captures and form.typed query values alike, so the public text no longer names the route. the go bench comparator answers the same text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #169
Plan:
router.bad_parameter, the error every built-in decoder returns, now answers the neutralinvalid parameter, since the same decoders serve path captures andform.typedquery values. The router dispatch test and the querytyped__route_decoderstest pin the text on both paths. The Go bench comparator answers the same text so the two servers stay byte-for-byte comparable.Decisions the issue did not settle:
router.compilesites keepinvalid route parameter. They reject a route's parameter declaration at compile time, never a client value, so the text names its source correctly (the issue's "names the source" option).Ran:
mach test . --filter dispatch__typed_paramsand--filter typed__route_decoders,mach fmt --checkon root and demo.