Repository navigation
Conversation
…used import The four registry arrays in secret.mach were sized by a literal 8, so changing MAX_RESOLVERS would silently desync them from the loops that walk them. router.mach imported opt without using it, which warned on every build.
octalide
marked this pull request as ready for review
September 27, 2026 06:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #186
Sizes the four
secret.machregistry arrays byMAX_RESOLVERSinstead of a literal8, and removes the unuseduse std.types.option.opt;fromsrc/router.mach.Ran locally:
mach build .(no warnings),mach test . --filter secretand--filter router,mach fmt --checkon the root,demoanddoc/bench/laurel.