Repository navigation
Conversation
Chrome.pad is now theme.Edges and overlay sizing and toast cards use each side, as window bodies do. Built-in themes set equal sides on overlay, tooltip and toast, so their look is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
Plan
overlay.Chrome.padbecomestheme.Edges, read throughcontext.px_edgeslike window padding.padto equal sides on overlay (0), tooltip and toast (theme pad), so their look is unchanged.overlay__pads_each_side_from_its_stylesets an asymmetricoverlay.padand checks box growth and content offset.Ran
mach test .(233 passed) andmach fmt . --check.