Repository navigation
chore: regenerate the gallery golden with the whole title tab - #200
Merged
Merged
Conversation
#198 lays tabs out with their separator, so the gallery's docked title tab is one pixel wider and draws its label whole. the old golden had the bug in it: the title cut to an ellipsis. every changed line is in the title row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#198 lays tabs out with their separator, so the gallery's docked title tab is 1 px wider and draws its label whole. The old golden had the bug baked in: three
.glyph quads, the title cut to an ellipsis. Every changed line is in the 0 to 16 px title row. Regenerated from a clean build of dev, and the gallery and panel tests pass.