Repository navigation
Conversation
tabs.width rebuilt every tab's width as least plus the rest times the shrink factor. at a factor of one that sum can land a hair short of the natural width in floating point, so the label box came out a fraction of a pixel narrower than the label and fit_box cut it with an ellipsis. a tab the bar has room for now takes its natural width directly. the test sweeps paddings that do not land on whole pixels and fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194
tabs.widthrebuilt each tab's width asleast + (natural - least) * fit. Atfit = 1that sum can come out a hair short ofnaturalin floating point, so the label box was a fraction of a pixel narrower than the label, andfit_box(#177) cut it with an ellipsis even when the bar had room to spare. octalide/ac's docked tab strips all showed "Behavi…".A tab the bar has room for now takes its natural width directly. The fix is in the lossy reconstruction, not a tolerance in
fit_box.Test:
bar__unshrunk_tabs_are_their_natural_widthsweeps paddings that don't land on whole pixels (as a scaled theme gives), with closable and unclosable tabs. It fails on dev (exit 2) and passes with the fix.Ran:
mach test .(223 pass),mach fmt --check ., and the gallery and panel demo tests aftermach dep pull. Goldens unchanged.