Repository navigation
Conversation
each field table row carries lo and hi, the range a UNIT_FACTOR value takes, and 0 for the other units. a test holds the table to it.
the hand-coded 0 to 1 cap on factors and 0 to 2 on the motion fields give way to each field's own lo and hi.
octalide
marked this pull request as ready for review
October 1, 2026 16:45
…old caps could not give
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192
Plan
theme.Fieldgainsloandhi: the range aUNIT_FACTORvalue takes, 0 and 0 for the other units. Every row ofFIELDSstates them.plot.areaand<kind>.overfloware 0 to 1, the six motion fields 0 to 2.GROUP_MOTION. Colors stay 0 to 1 and lengths 0 toLENGTH_MAX.table__factors_state_a_range_and_others_noneholds the table to the contract, andeditor__factor_slider_spans_its_fields_rangedragsmotion.hover_easeto the end of its slider and expects 2.Decided here: the range is lo and hi rather than a max alone, so a factor that goes below 0 needs no layout change. The README field table is unchanged (the range isn't shown in it), so
document__is_the_readme_field_tablestill passes as is.Ran: release build,
mach test . --filter editor|table__|document__, demo/gallery and demo/panel tests (goldens unchanged),mach fmt --check ..